From f48df0ffdd569d55d30823b5b6cfb8e924d9a2e4 Mon Sep 17 00:00:00 2001 From: Christoph Gysin Date: Tue, 31 Mar 2015 14:12:06 +0300 Subject: [PATCH] flake8: Fix F401,F403 This commit fixes the following flake8 issues: F401 'foo' imported but unused F403 'from foo import *' used; unable to detect undefined names Change-Id: I163224c65f54a2e495d6469c1c26a115ad192e23 --- .../alembic/versions/1cdd4e2e74c_add_revision_indexes.py | 1 - gertty/alembic/versions/2a11dd14665_fix_account_table.py | 1 - .../versions/56e48a4a064a_increase_status_field_width.py | 1 - gertty/db.py | 4 ++-- gertty/search/parser.py | 4 ++-- gertty/view/change.py | 1 - gertty/view/change_list.py | 1 - gertty/view/project_list.py | 1 - gertty/view/side_diff.py | 9 +++------ gertty/view/unified_diff.py | 8 +++----- tox.ini | 2 +- 11 files changed, 11 insertions(+), 22 deletions(-) diff --git a/gertty/alembic/versions/1cdd4e2e74c_add_revision_indexes.py b/gertty/alembic/versions/1cdd4e2e74c_add_revision_indexes.py index b517b8e..928a10b 100644 --- a/gertty/alembic/versions/1cdd4e2e74c_add_revision_indexes.py +++ b/gertty/alembic/versions/1cdd4e2e74c_add_revision_indexes.py @@ -11,7 +11,6 @@ revision = '1cdd4e2e74c' down_revision = '4a802b741d2f' from alembic import op -import sqlalchemy as sa def upgrade(): diff --git a/gertty/alembic/versions/2a11dd14665_fix_account_table.py b/gertty/alembic/versions/2a11dd14665_fix_account_table.py index bfbf8ca..6b55170 100644 --- a/gertty/alembic/versions/2a11dd14665_fix_account_table.py +++ b/gertty/alembic/versions/2a11dd14665_fix_account_table.py @@ -11,7 +11,6 @@ revision = '2a11dd14665' down_revision = '4cc9c46f9d8b' from alembic import op -import sqlalchemy as sa def upgrade(): diff --git a/gertty/alembic/versions/56e48a4a064a_increase_status_field_width.py b/gertty/alembic/versions/56e48a4a064a_increase_status_field_width.py index b4522a0..a95e155 100644 --- a/gertty/alembic/versions/56e48a4a064a_increase_status_field_width.py +++ b/gertty/alembic/versions/56e48a4a064a_increase_status_field_width.py @@ -10,7 +10,6 @@ Create Date: 2014-05-05 11:49:42.133569 revision = '56e48a4a064a' down_revision = '44402069e137' -from alembic import op import sqlalchemy as sa from gertty.dbsupport import sqlite_alter_columns diff --git a/gertty/db.py b/gertty/db.py index 35d240c..8547b93 100644 --- a/gertty/db.py +++ b/gertty/db.py @@ -20,9 +20,9 @@ import threading import alembic import alembic.config import sqlalchemy -from sqlalchemy import create_engine, MetaData, Table, Column, Integer, String, Boolean, DateTime, Text, select, func +from sqlalchemy import create_engine, MetaData, Table, Column, Integer, String, Boolean, DateTime, Text from sqlalchemy.schema import ForeignKey -from sqlalchemy.orm import mapper, sessionmaker, relationship, column_property, scoped_session +from sqlalchemy.orm import mapper, sessionmaker, relationship, scoped_session from sqlalchemy.orm.session import Session from sqlalchemy.sql import exists from sqlalchemy.sql.expression import and_ diff --git a/gertty/search/parser.py b/gertty/search/parser.py index a0e2939..8daa4a9 100644 --- a/gertty/search/parser.py +++ b/gertty/search/parser.py @@ -16,12 +16,12 @@ import datetime import re import ply.yacc as yacc -from sqlalchemy.sql.expression import and_, or_, not_, exists, select +from sqlalchemy.sql.expression import and_, or_, not_, select import gertty.db import gertty.search -from tokenizer import tokens +from tokenizer import tokens # NOQA def SearchParser(): precedence = ( # NOQA diff --git a/gertty/view/change.py b/gertty/view/change.py index 335dbde..ec43040 100644 --- a/gertty/view/change.py +++ b/gertty/view/change.py @@ -19,7 +19,6 @@ import urlparse import urwid -from gertty import gitrepo from gertty import keymap from gertty import mywid from gertty import sync diff --git a/gertty/view/change_list.py b/gertty/view/change_list.py index 20dfb8f..d2fa671 100644 --- a/gertty/view/change_list.py +++ b/gertty/view/change_list.py @@ -18,7 +18,6 @@ import logging import urwid from gertty import keymap -from gertty import mywid from gertty import sync from gertty.view import change as view_change from gertty.view import mouse_scroll_decorator diff --git a/gertty/view/project_list.py b/gertty/view/project_list.py index abba444..97ef5e2 100644 --- a/gertty/view/project_list.py +++ b/gertty/view/project_list.py @@ -17,7 +17,6 @@ import logging import urwid from gertty import keymap -from gertty import mywid from gertty import sync from gertty.view import change_list as view_change_list from gertty.view import mouse_scroll_decorator diff --git a/gertty/view/side_diff.py b/gertty/view/side_diff.py index a5eddab..493f65c 100644 --- a/gertty/view/side_diff.py +++ b/gertty/view/side_diff.py @@ -12,15 +12,12 @@ # License for the specific language governing permissions and limitations # under the License. -import datetime -import logging - import urwid from gertty import keymap -from gertty import mywid -from gertty import gitrepo -from gertty.view.diff import * +from gertty.view.diff import BaseDiffComment, BaseDiffCommentEdit, BaseDiffLine +from gertty.view.diff import BaseFileHeader, BaseFileReminder, BaseDiffView +from gertty.view.diff import LineContext LN_COL_WIDTH = 5 diff --git a/gertty/view/unified_diff.py b/gertty/view/unified_diff.py index 0d39126..714a30a 100644 --- a/gertty/view/unified_diff.py +++ b/gertty/view/unified_diff.py @@ -13,14 +13,12 @@ # License for the specific language governing permissions and limitations # under the License. -import datetime -import logging - import urwid -from gertty import mywid from gertty import gitrepo -from gertty.view.diff import * +from gertty.view.diff import BaseDiffCommentEdit, BaseDiffComment, BaseDiffLine +from gertty.view.diff import BaseFileHeader, BaseFileReminder, BaseDiffView +from gertty.view.diff import LineContext LN_COL_WIDTH = 5 diff --git a/tox.ini b/tox.ini index 0f01214..8378151 100644 --- a/tox.ini +++ b/tox.ini @@ -31,6 +31,6 @@ deps = flake8 commands = {posargs} [flake8] -ignore = W,E,F401,F403 +ignore = W,E show-source = True exclude = .venv,.tox,dist,doc,build,*.egg