As per the governance resolution https://review.openstack.org/119875,
projects should have a docs environment in their tox.ini testing
interface. Rename the doc environment to docs.
Change-Id: Ib3c26755b780e6910df3e18dffc5db24c30c0324
Update the openstack example config file with some additional help
text about the username and password. The first time I ran this it
took me a little bit to figure out the right password to use. I
didn't realize I needed to go generate a password in my gerrit
settings. Hopefully this note will avoid confusion by someone else in
the future.
Change-Id: If93ec938e48f624aff4741b19d95e03abb8c8a9c
If a user is crazy enough to want to do something like run gertty
on top of MySQL, most things work ... except for a few places where
bare use of SQL in the migrations bypass identifier quoting.
Change-Id: I0145389d645ca647d2e599c79f5266f60dec85f4
If the currently displayed change was opened via a link and there
is a change list in the navigation hierarchy, Gertty will find
the change list but not the current change. Protect against a
crash in that case and do nothing.
Change-Id: I85b00b8cf6af258b672f15352b75803d931c59a6
When the currently displayed change was not arrived at from a
query listing (for example, was directly opened), there may be no
change list to find in the navigation history. Don't try to use
it if that's the case.
Change-Id: I6fdb1ed2e16675bf1be3726b836130b695225b6b
We need more control over diff colorization for proper rendering
and processing. Ensure that local settings don't cause us to
blow up when we're doing it.
Change-Id: I07fc445d9328c9df1ed52e8b328cce6fbea78f43
This should probably never happen, but it has anyway, so assume the
email field is a utf8 string. This should avoid crashing in case
someone has a utf8 email, but may not be a complete solution to
the case that an email is in a non-ascii, non-utf8 charset.
Change-Id: I95ed91e5fdfe35b73550e1824e609a0b1d388b3a
Gertty previously supported F1 and '?' as help keys, but '?' was
accidentally switched to 'h' when customizable keymaps were added.
Switch back to the old value.
Change-Id: Iaab801e4d53c59e6f45021ddfaa85bb740898ce8
Gerrit supports up to 10 queries in a single request. Do the project
sync queries in batches of 10 to reduce network traffic.
Change-Id: I9aecbb91c1898d436fc54d21d1910badaddfef3b
When a change no longer was needed by another change, gertty would
crash when attempting to remove the line from the display.
Change-Id: I58492b43140fcfff05badf0be978b786118e0efb
Story: 262
The sync module would indirectly modify the status widget (so that
the count of sync actions would be up to date). If this happened
while urwid was drawing the screen, urwid may invalidate cached
information in mid-redraw, resulting in an exception and crash.
This updates the StatusHeader widget so that changes are merely
recorded to internal variables, and the actual widgets are updated
by a refresh method called from within the main loop.
Change-Id: I27043533d33d44aae31005670a1b727e9cc7bb90
Story: 260
So that it's easy to look up the key values that are supported for
those options in the YAML file.
Change-Id: Idc08d4319582ead001806549809d2d2bee0ff06c
To further distinguish the local vs remote cherry pick operation,
add 'local' to the name in the keymap. Same for checkout (though
it has no remote).
Change-Id: Idcca8a9dbddfc571eda32634a7dc2a7bfb8a070a
Add the fields needed to support topic and commit message editing,
cherry-picking, rebasing, and abandon/restore.
Change-Id: If5103701c008907eade5dee50fc1ed18521188df
When querying for a list of changes to sync, use the sortkey to
handle multiple pages of query results. By default, Gerrit only
returns 500 results.
Change-Id: I12049b4dcfa796650099b9ba71377a5bcf3feae0
DB migration to rename pending -> draft. Keep pending column on
messages to mean "ready to upload". Indicate whether messages are
drafts in change display. Update display of (draft) messages when
their contents change. Also store draft votes, but don't display
them until finalized (pending upload). Also remove 'drafts' flag
from revisions if that revision has a pending upload.
Change-Id: Iff427c0c1664351ce8e2d61be2f79f3bfa1f989d
Now that change refs are stored locally, the only time a local repo
should be missing revisions is when it is newly cloned. Handle the
case where a user deletes the local repo automatically (when gertty
starts and a repo does not exist for a subscribed project, perform
a missing refs check on that project).
If the user knows something is wrong, they can supply the
--fetch-missing-refs flag at startup and an exhaustive check will
be run of all projects.
Otherwise, do nothing.
Change-Id: Iedebbe4b05ec1293b82c651587e42004444dc4a8
Set it to the divider between the related patches and the patchsets
so that the cursor is closer to the actions.
Change-Id: Id02d230830ab431f5969a1f014d17416e731ea22
Don't attempt to show the screen help. Display the welcome screen
when there are no subscribed projects (rather than when the screen
is empty, since that can now happen if there are no projects with
pending reviews).
Change-Id: I4c4215d61a00c303ad7480ed6c49b7bab0d36463
Multiple keymaps may be added in either Gertty itself or in config
files, individual keys may be overriden in the standard map, and
the map can be selected via config file or command line option
just as palettes are.
Change the help text to be dynamically generated based on the
current keymap.
Change-Id: I5f8e63897fab3aa14493465256b5d4516cf47dcd
For use in a terminal with a white background. Also add a config
file option that selects the default palette.
Change-Id: I1b4a61efa3d9011bfe089471fa80ad4563d9ba01
Use 'L' to toggle listing of projects with unreviewed changes.
Clean up some nomenclature around that feature.
Change-Id: I314500300587d56a4c56683203878c5fbaa37ee3
If the user is viewing only their subscribed projects, it makes sense to
let them toggle between seeing all projects and only those with
unreviewed reviews.
When they've chosen to list unsubscribed projects as well, this seems to
make less sense. The unsubscribed projects will all have no unreviewed
reviews, so no unsubscribed projects would ever be listed.
In effect, this means that to list all projects the user now has to
press two keys (l,a) rather than one (l).
This commit ignores the active_only flag when listing unsubscribed
projects, restoring the ability to see a list of all projects just by
hitting one key (l)
Two nits I'm aware of:
* If the user is listing all projects and presses a, the active_only
flag will be silently toggled, which may be surprising when they
switch back to only subscribed projects and the view is different to
when they left that view
* If there are circumstances I haven't thought of that could lead to
having unreviewed reviews in an unsubscribed project, it might make
sense to pay attention to this flag, in which case this patch won't
quite do what we want.
Change-Id: Id5c27cde7b9536aa9fb0f8ba74276b07019f5d17
So I find scrolling around to find the next project to review in gets
to be a bit of a nuisance. This patch hides fully reviewed projects
unless 'a' is pushed.
Change-Id: I09813184c17464171b0af8530f6e394b37b9a10d
Add an option to commentlinks to indicate they are test results
and use that to collect results and display them at the top of the
change view. The value of 'test-results' is used as the job key
when creating the table (so that only the most recent result for
a given job run on the latest patchset is included). This is
particularly effective along with the hide-comment system to hide
the results from the comment stream.
Change-Id: I54a787914aab18ad2a2a5ca4cc79dd66add2c588
Indicate if a change depends on an obsolete revision of another
change. Also, indicate that a change is needed by a change even
if the dependency is on an older patchset.
Change-Id: I8f1653c917979d3865d5e494cd53789e65ea928b
Refactor commonalities into base diff view, and implement unified
and side-by-side diff views. Configurable in the config yaml
file.
Change-Id: Ia8d9241d04f3e7f480618e7efe1d3792f530e173
When searching for a change by change ID, we attempt to immediately
since it. Fix some errors related to that.
Change-Id: I86c57f1569dde43b267dca2283ede725b04d4764
On very wide displays, the change screen can have lines that are
too long making them difficult to scan. Wrap them at 80 columns
in the review message display.
Change-Id: I3a79137a5c1412d3cdeb0e7c2f918a2960ca818e
Monty Taylor
Jenkins
Russell Bryant
James E. Blair
Doug Hellmann
James Polley
Robert Collins