53c7e3b4ae
Patch Set 1: (3 comments) Patch-set: 1
72 lines
2.1 KiB
Plaintext
72 lines
2.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "7647f534_dba61cb5",
|
|
"filename": "gertty/mywid.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 67,
|
|
"author": {
|
|
"id": 1
|
|
},
|
|
"writtenOn": "2024-02-26T19:58:55Z",
|
|
"side": 1,
|
|
"message": "Nit: other similar methods use the constants like urwid.FLOW (see line 59)",
|
|
"revId": "43af55ec11980f1598fa0200fa00027e19252868",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "9e363253_7be6269a",
|
|
"filename": "gertty/mywid.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 69,
|
|
"author": {
|
|
"id": 19119
|
|
},
|
|
"writtenOn": "2024-02-26T20:12:12Z",
|
|
"side": 1,
|
|
"message": "technically, this method can be updated to support FIXED sizing instead,\nbut this requires extra testing: `pack` will always return size needed to fit all contents without re-formatting from original format (no text clipping/lines split/...)",
|
|
"revId": "43af55ec11980f1598fa0200fa00027e19252868",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "be4ab084_b3dc596b",
|
|
"filename": "gertty/mywid.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 360,
|
|
"author": {
|
|
"id": 1
|
|
},
|
|
"writtenOn": "2024-02-26T19:58:55Z",
|
|
"side": 1,
|
|
"message": "Nit: this could be urwid.FLOW",
|
|
"revId": "43af55ec11980f1598fa0200fa00027e19252868",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "207fbcbc_2c8c7931",
|
|
"filename": "gertty/mywid.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 361,
|
|
"author": {
|
|
"id": 19119
|
|
},
|
|
"writtenOn": "2024-02-26T20:12:12Z",
|
|
"side": 1,
|
|
"message": "Mouse event is `maxcol` dependent (and widget is closer to the container, than to the formatted text)",
|
|
"revId": "43af55ec11980f1598fa0200fa00027e19252868",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |