windmill
/
ansible-role-carbon
Code Issues Proposed changes

Update patch set 14 

Patch Set 14:

(1 comment)

Patch-set: 14
Label: Verified=0
This commit is contained in:
Gerrit User 6816 2018-04-26 16:42:21 +00:00 committed by Gerrit Code Review
parent 5e2831117e
commit ab61c4b31b
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
310fe98f810e3eb192b1fb071e05f395251dfaa7
View File

@ -52,6 +52,24 @@
"revId": "310fe98f810e3eb192b1fb071e05f395251dfaa7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f6a8fd7_839f6164",
"filename": "defaults/main.yaml",
"patchSetId": 14
},
"lineNbr": 49,
"author": {
"id": 6816
},
"writtenOn": "2018-04-26T16:42:21Z",
"side": 1,
"message": "If these paths are per distribution and static unless a venv is used, why not set them in a vars/main.yml file as a dict which can be referenced in the install.\n\nOf course it could also be in defaults to make it easier to override, but this is unlikely to be overridden.",
"parentUuid": "9f6a8fd7_469cfc5c",
"revId": "310fe98f810e3eb192b1fb071e05f395251dfaa7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}