windmill
/
ansible-role-diskimage-builder
Code Issues Proposed changes

Pass list of packages directly to package task 

There is no need to loop over the list of packages, this is actually
slower.

Change-Id: I24666d652cbb3806b418b7f0fb0839d4bb2614ea
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
This commit is contained in:
Paul Belanger 2018-04-14 16:21:31 -04:00
parent 46856cf039
commit 584a86ece6
No known key found for this signature in database
GPG Key ID: 611A80832067AF38
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tasks/install.yaml
View File

@ -30,17 +30,15 @@
- name: Ensure build dependencies are installed.
become: yes
package:
name: "{{ item }}"
name: "{{ diskimage_builder_build_depends }}"
state: installed
with_items: "{{ diskimage_builder_build_depends }}"
when: diskimage_builder_install_method == 'git'
- name: Ensure dependencies are installed.
become: yes
package:
name: "{{ item }}"
name: "{{ diskimage_builder_depends }}"
state: installed
with_items: "{{ diskimage_builder_depends }}"
when: diskimage_builder_install_method == 'git' or diskimage_builder_install_method == 'pip'
- include: "install/{{ diskimage_builder_install_method }}.yaml"