Switch to yamllint for tox -elinters

It was a lot of overhead, with little gain, to run molecule lint.
Switch back to just using yamllint.

Change-Id: Ie4e4d5d77dcb864f7b76cd356cab7adf9516d1b3
Signed-off-by: Paul Belanger <pabelanger@redhat.com>

.yamllint

@@ -1,5 +1,8 @@
 extends: default
 
+ignore: |
+  .tox
+
 rules:
   braces:
     max-spaces-inside: 1

tests/collect-logs.yaml

@@ -1,3 +1,4 @@
+---
 - hosts: all
   tasks:
     - name: Ensure journald logs directory exists
@@ -23,7 +24,7 @@
         - "{{ ansible_user_dir }}/{{ zuul.project.src_dir }}/junit.xml"
 
     - name: Prepare nodepool log files
-      become: yes
+      become: true
       synchronize:
         dest: "{{ zuul_output_dir }}/logs/logs"
         rsync_opts:

tests/playbooks/pre.yaml

@@ -1,3 +1,4 @@
+---
 - hosts: all
   tasks:
     # TODO(pabelanger): Remove once this lands in our base job in
@@ -7,7 +8,7 @@
         name: ensure-output-dirs
 
     - name: Disable extra wheels mirror
-      become: yes
+      become: true
       lineinfile:
         dest: /etc/pip.conf
         regexp: ^extra-index-url

tests/playbooks/run-post.yaml

@@ -1,3 +1,4 @@
+---
 - hosts: all
   tasks:
     - name: Run testinfra validation

tox.ini

@@ -33,7 +33,7 @@ exclude=.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build
 
 [testenv:linters]
 commands =
-  molecule lint
+  yamllint -s .
 
 [testenv:molecule]
 sitepackages = True