Browse Source

Fix truthy value should be true or false

While testing out molecule, the following warnings were raised with its
linter.  Lets fix them to keep it happy.

Change-Id: I698f65daa58822f7befc72b9dcbf1f2d668cab02
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
changes/00/593100/1
Paul Belanger 10 months ago
parent
commit
48531f50f1
6 changed files with 20 additions and 20 deletions
  1. 2
    2
      defaults/main.yaml
  2. 5
    5
      tasks/config.yaml
  3. 1
    1
      tasks/install.yaml
  4. 1
    1
      tasks/install/pip.yaml
  5. 3
    3
      tasks/pre.yaml
  6. 8
    8
      tasks/service.yaml

+ 2
- 2
defaults/main.yaml View File

@@ -84,13 +84,13 @@ nodepool_file_nodepool_launcher_service_config_group: root
84 84
 nodepool_file_nodepool_launcher_service_config_owner: root
85 85
 
86 86
 nodepool_service_nodepool_builder_daemon_reload: true
87
-nodepool_service_nodepool_builder_enabled: yes
87
+nodepool_service_nodepool_builder_enabled: true
88 88
 nodepool_service_nodepool_builder_manage: true
89 89
 nodepool_service_nodepool_builder_name: nodepool-builder
90 90
 nodepool_service_nodepool_builder_state: started
91 91
 
92 92
 nodepool_service_nodepool_launcher_daemon_reload: true
93
-nodepool_service_nodepool_launcher_enabled: yes
93
+nodepool_service_nodepool_launcher_enabled: true
94 94
 nodepool_service_nodepool_launcher_manage: true
95 95
 nodepool_service_nodepool_launcher_name: nodepool-launcher
96 96
 nodepool_service_nodepool_launcher_state: started

+ 5
- 5
tasks/config.yaml View File

@@ -13,7 +13,7 @@
13 13
 # under the License.
14 14
 ---
15 15
 - name: Create required directories.
16
-  become: yes
16
+  become: true
17 17
   file:
18 18
     group: "{{ nodepool_user_group }}"
19 19
     owner: "{{ nodepool_user_name }}"
@@ -26,7 +26,7 @@
26 26
     - /var/log/nodepool
27 27
 
28 28
 - name: Install nodepool configuration.
29
-  become: yes
29
+  become: true
30 30
   template:
31 31
     dest: "{{ nodepool_file_nodepool_yaml_dest }}"
32 32
     group: "{{ nodepool_file_nodepool_yaml_group }}"
@@ -36,7 +36,7 @@
36 36
   register: nodepool_file_nodepool_yaml
37 37
 
38 38
 - name: Install nodepool secure configuration.
39
-  become: yes
39
+  become: true
40 40
   template:
41 41
     dest: "{{ nodepool_file_secure_conf_dest }}"
42 42
     group: "{{ nodepool_file_secure_conf_group }}"
@@ -46,7 +46,7 @@
46 46
   register: nodepool_file_secure_conf
47 47
 
48 48
 - name: Install builder logging configuration file.
49
-  become: yes
49
+  become: true
50 50
   template:
51 51
     dest: "{{ nodepool_file_builder_logging_conf_dest }}"
52 52
     group: "{{ nodepool_file_builder_logging_conf_group }}"
@@ -56,7 +56,7 @@
56 56
   register: nodepool_file_builder_logging_conf
57 57
 
58 58
 - name: Install launcher logging configuration file.
59
-  become: yes
59
+  become: true
60 60
   template:
61 61
     dest: "{{ nodepool_file_launcher_logging_conf_dest }}"
62 62
     group: "{{ nodepool_file_launcher_logging_conf_group }}"

+ 1
- 1
tasks/install.yaml View File

@@ -18,7 +18,7 @@
18 18
   when: nodepool_build_depends is not defined
19 19
 
20 20
 - name: Ensure build dependencies are installed
21
-  become: yes
21
+  become: true
22 22
   package:
23 23
     name: "{{ nodepool_build_depends }}"
24 24
     state: installed

+ 1
- 1
tasks/install/pip.yaml View File

@@ -13,7 +13,7 @@
13 13
 # under the License.
14 14
 ---
15 15
 - name: Install nodepool using pip.
16
-  become: yes
16
+  become: true
17 17
   pip:
18 18
     executable: "{{ nodepool_pip_executable|default(omit) }}"
19 19
     editable : "{{ nodepool_pip_editable|default(omit) }}"

+ 3
- 3
tasks/pre.yaml View File

@@ -13,14 +13,14 @@
13 13
 # under the License.
14 14
 ---
15 15
 - name: Create group account.
16
-  become: yes
16
+  become: true
17 17
   group:
18 18
     name: "{{ nodepool_user_group }}"
19 19
 
20 20
 - name: Create user account.
21
-  become: yes
21
+  become: true
22 22
   user:
23
-    createhome: yes
23
+    createhome: true
24 24
     group: "{{ nodepool_user_group }}"
25 25
     home: "{{ nodepool_user_home }}"
26 26
     name: "{{ nodepool_user_name }}"

+ 8
- 8
tasks/service.yaml View File

@@ -73,7 +73,7 @@
73 73
   when: nodepool_file_nodepool_launcher_service_config_src is not defined
74 74
 
75 75
 - name: Install nodepool-builder service script into place.
76
-  become: yes
76
+  become: true
77 77
   template:
78 78
     dest: "{{ nodepool_file_nodepool_builder_service_dest }}"
79 79
     group: "{{ nodepool_file_nodepool_builder_service_group }}"
@@ -84,7 +84,7 @@
84 84
   when: nodepool_file_nodepool_builder_service_manage
85 85
 
86 86
 - name: Create nodepool-builder service config directory.
87
-  become: yes
87
+  become: true
88 88
   file:
89 89
     group: "{{ nodepool_file_nodepool_builder_service_config_group }}"
90 90
     owner: "{{ nodepool_file_nodepool_builder_service_config_owner }}"
@@ -93,7 +93,7 @@
93 93
   when: nodepool_file_nodepool_builder_service_config_manage
94 94
 
95 95
 - name: Install nodepool-builder service config into place.
96
-  become: yes
96
+  become: true
97 97
   template:
98 98
     dest: "{{ nodepool_file_nodepool_builder_service_config_dest  }}"
99 99
     group: "{{ nodepool_file_nodepool_builder_service_config_group  }}"
@@ -104,7 +104,7 @@
104 104
   when: nodepool_file_nodepool_builder_service_config_manage
105 105
 
106 106
 - name: Install nodepool-launcher service script into place.
107
-  become: yes
107
+  become: true
108 108
   template:
109 109
     dest: "{{ nodepool_file_nodepool_launcher_service_dest }}"
110 110
     group: "{{ nodepool_file_nodepool_launcher_service_group }}"
@@ -115,7 +115,7 @@
115 115
   when: nodepool_file_nodepool_launcher_service_manage
116 116
 
117 117
 - name: Create nodepool-launcher service config directory.
118
-  become: yes
118
+  become: true
119 119
   file:
120 120
     group: "{{ nodepool_file_nodepool_launcher_service_config_group }}"
121 121
     owner: "{{ nodepool_file_nodepool_launcher_service_config_owner }}"
@@ -124,7 +124,7 @@
124 124
   when: nodepool_file_nodepool_launcher_service_config_manage
125 125
 
126 126
 - name: Install nodepool-launcher service config into place.
127
-  become: yes
127
+  become: true
128 128
   template:
129 129
     dest: "{{ nodepool_file_nodepool_launcher_service_config_dest  }}"
130 130
     group: "{{ nodepool_file_nodepool_launcher_service_config_group  }}"
@@ -135,7 +135,7 @@
135 135
   when: nodepool_file_nodepool_launcher_service_config_manage
136 136
 
137 137
 - name: Enable nodepool-builder service.
138
-  become: yes
138
+  become: true
139 139
   systemd:
140 140
     daemon_reload: "{{ nodepool_service_nodepool_builder_daemon_reload }}"
141 141
     enabled: "{{ nodepool_service_nodepool_builder_enabled }}"
@@ -145,7 +145,7 @@
145 145
   when: nodepool_service_nodepool_builder_manage
146 146
 
147 147
 - name: Enable nodepool-launcher service.
148
-  become: yes
148
+  become: true
149 149
   systemd:
150 150
     daemon_reload: "{{ nodepool_service_nodepool_launcher_daemon_reload }}"
151 151
     enabled: "{{ nodepool_service_nodepool_launcher_enabled }}"

Loading…
Cancel
Save