Update nodepool_git_dest location

Stop using /opt folder to store the location of git checkout. We don't
actually need to be root user to do that.

Change-Id: Icdb2905cf66fd9ab414d009ad3d782bc802e037d
Signed-off-by: Paul Belanger <pabelanger@redhat.com>

defaults/main.yaml

@@ -55,7 +55,7 @@ nodepool_file_launcher_logging_conf_owner: "{{ nodepool_user_name }}"
 nodepool_file_launcher_logging_conf_src: etc/nodepool/launcher-logging.conf
 
 # tasks/install.yaml
-nodepool_git_dest: /opt/ansible-role-nodepool/git/openstack-infra/nodepool
+nodepool_git_dest: "{{ ansible_user_dir }}/src/git.openstack.org/openstack-infra/nodepool"
 nodepool_git_uri: https://git.openstack.org/openstack-infra/nodepool
 nodepool_git_version: master
 # nodepool_git_refspec:

tasks/install/git.yaml

@@ -13,7 +13,6 @@
 # under the License.
 ---
 - name: Git clone nodepool.
-  become: yes
   git:
     dest: "{{ nodepool_git_dest }}"
     refspec: "{{ nodepool_git_refspec|default(omit) }}"

tests/test.yaml

@@ -14,7 +14,6 @@
 ---
 - hosts: all
   vars:
-    nodepool_git_dest: "{{ ansible_user_dir }}/src/git.openstack.org/openstack-infra/nodepool"
     nodepool_git_update: false
     nodepool_pip_executable: pip3
     rolename: ansible-role-nodepool