windmill
/
ansible-role-zuul-registry
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 4162 <4162@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 9268 \u003c9268@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Paul Belanger replied on the change"}
Attention: {"person_ident":"Gerrit User 4162 \u003c4162@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Paul Belanger replied on the change"}
This commit is contained in:
Gerrit User 4162 2021-11-22 17:26:57 +00:00 committed by Gerrit Code Review
parent bfea2f5157
commit d95c39316d
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
7096fb3e0d43620c13d8fc96eba01a4bc3ae0276 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "c9e28f63_84c40e0b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 4162
},
"writtenOn": "2021-11-22T17:26:57Z",
"side": 1,
"message": "We don\u0027t want to change the default service we ship. The better way to do this, is add an override.conf file using zuul_registry_file_zuul_registry_service_config_src\n\nhttps://opendev.org/windmill/ansible-role-zuul/src/branch/master/tests/playbooks/run.yaml#L18 and https://opendev.org/windmill/ansible-role-zuul/src/branch/master/tests/playbooks/templates/etc/systemd/system/override.conf.j2 is the systemd config file.\n\nWhich systemd will properly merge",
"revId": "7096fb3e0d43620c13d8fc96eba01a4bc3ae0276",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}