x/browbeat
Code Issues Proposed changes

Update patch set 2

Browse Source 
Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 30421 \u003c30421@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_30421\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 34486 \u003c34486@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_30421\u003e replied on the change"}
This commit is contained in:
Gerrit User 30421 2024-04-05 04:48:59 +00:00 committed by Gerrit Code Review
parent 5b7889c3e0
commit 6fc952452c
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
d70201a54b80a2647cccbe4a0f8df253b26f67d3 Normal file
View File

@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "fd5e469c_d2fdefc4",
"filename": "ansible/install/roles/collectd/vars/defaults.yml",
"patchSetId": 2
},
"lineNbr": 1,
"author": {
"id": 30421
},
"writtenOn": "2024-04-05T04:48:59Z",
"side": 1,
"message": "can you move this variable to group_vars/all.yaml as it will be configurable. Also no need of any default. Let the user update it when enabling the sqlalchemy collectd plugin.",
"range": {
"startLine": 1,
"startChar": 0,
"endLine": 1,
"endChar": 12
},
"revId": "d70201a54b80a2647cccbe4a0f8df253b26f67d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}