So turns out that E111 is the multiple of four indentation check
it's my fault that ended up in the tox.ini last time I was messing
with it and it seems to have come back to bite only me, as Yoda and
Tools functions, also for Yoda are the only victims of bad indentation.
After a strong recomendation by a friend I'm giving autopep8 a try.
Change-Id: Ia067bc60fad1200f577624aac2e979dfc26ec05d
So up until recently the 'linters' CI run ran both
the pep8 and the Ansible linters, after some review
I can only conclude that it actually was not supposed
to do that and I should have seperate Python and Ansible
linters jobs.
Anyways because of this the pep linters where out for a
few days an we got exactly two minor pep errors into our
repo.
Change-Id: I66f82021c71f89a775e05c411ee1af2dba3a1c7b
flake8 doesn't actually have any issues if you do and
adding exclusions deletes flake8's rather comprehensive
list of exceptions enabled by default.
Change-Id: I2097a4ad095e60064c16d6e1948996f4b11d7af8
Remove old and unused constraints environments from tox.ini. Those
have never been used. Use standard environments as default list.
Note that the standard jobs - as run in OpenStack CI - did not use
constraints previouly and do not use them now. So, this keep the status
quo for CI.
For more information about constraints see:
http://lists.openstack.org/pipermail/openstack-dev/2016-August/101474.html
Change-Id: If99dc4a9398988da769d49a57e22f58b7d83ae74
This commit enanbles Ansible linting and does some
minor refactoring to make existing Ansible roles
compatible with the new rules.
Several Ansible linting rules have been excluded to keep the number
of changes from being too onerous.
Also a new script in ci-scripts is used to check very config file
included in the Browbeat repo for validity using the template
Browbeat uses when it runs.
Here's a list of the new linting rules
* Ansible tasks must have names
* When you use shell you must use become not sudo
* Using become_user without using become is not allowed
* If a repo is pulled it must be a pinned version of commit, not latest
* Always_run is deprecated don't use it
* Variables without {{}} and not in when statements are deprecated don't use them
* No Trailing whitepaces
* YAML checking, catches big syntax errors but not less obvious ones
Change-Id: Ic531c91c408996d4e7d8899afe8b21d364998680
This change should disable the Ansible Linters in tox.ini
so that we can make the existing pep8 tests voting.
Linting should be re-enabled in tox once Ansible playbooks
have their errors corrected.
This commit also corrects some python errors that snuck into
Shaker.py
Change-Id: I5d64985849b9e31b91c9000dba7238cc79bd2009
This is the entry point for openstack gate jobs.
Change-Id: Icbebabf5ea439ef0ef20cdbda41fb9adc82965d1
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
