x/charm-ovn-relay-k8s
Code Issues Proposed changes

Remove use of stored state for service_ready

Browse Source 
Remove saving service_ready in stored state in
OVnRelayPebbleHandler class.

Change-Id: Ib222f9df3270728e912faa825a936ed29398252c
This commit is contained in:
Hemanth Nakkina 2023-01-06 14:07:14 +05:30
parent cc6315fa89
commit c442199eaa
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/charm.py
View File

@ -43,9 +43,6 @@ import ops_sunbeam.ovn.container_handlers as ovn_chandlers
from charms.observability_libs.v0.kubernetes_service_patch import ( from charms.observability_libs.v0.kubernetes_service_patch import (
KubernetesServicePatch, KubernetesServicePatch,
) )
from ops.framework import (
StoredState,
)
from ops.main import ( from ops.main import (
main, main,
) )
@ -84,13 +81,11 @@ class OVNRelayPebbleHandler(ovn_chandlers.OVNPebbleHandler):
self.setup_dirs() self.setup_dirs()
self.write_config(context) self.write_config(context)
self.start_service() self.start_service()
self._state.service_ready = True
class OVNRelayOperatorCharm(ovn_charm.OSBaseOVNOperatorCharm): class OVNRelayOperatorCharm(ovn_charm.OSBaseOVNOperatorCharm):
"""Charm the service.""" """Charm the service."""
_state = StoredState()
mandatory_relations = { mandatory_relations = {
"ovsdb-cms", "ovsdb-cms",
"certificates", "certificates",

2
tests/tests.yaml
View File

@ -61,7 +61,7 @@ target_deploy_status:
workload-status-message-regex: '^$' workload-status-message-regex: '^$'
mysql: mysql:
workload-status: active workload-status: active
workload-status-message-regex: '^$' workload-status-message-regex: '^Unit is ready.*$'
placement: placement:
workload-status: active workload-status: active
workload-status-message-regex: '^$' workload-status-message-regex: '^$'