From 4bd7b887ef55cb63188338f35c8885077635ba9a Mon Sep 17 00:00:00 2001 From: Gerrit User 7979 <7979@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Tue, 19 Apr 2016 21:34:34 +0000 Subject: [PATCH] Update patch set 3 Patch Set 3: (1 comment) Patch-set: 3 Reviewer: Gerrit User 7979 <7979@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0 --- 699dae47e3f7e66a0a804c17c996b5d0217c682c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/699dae47e3f7e66a0a804c17c996b5d0217c682c b/699dae47e3f7e66a0a804c17c996b5d0217c682c index 3ed10ea..6b5bb37 100644 --- a/699dae47e3f7e66a0a804c17c996b5d0217c682c +++ b/699dae47e3f7e66a0a804c17c996b5d0217c682c @@ -16,6 +16,24 @@ "revId": "699dae47e3f7e66a0a804c17c996b5d0217c682c", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false + }, + { + "key": { + "uuid": "1a122d0e_2740e633", + "filename": "ciwatch/events.py", + "patchSetId": 3 + }, + "lineNbr": 36, + "author": { + "id": 7979 + }, + "writtenOn": "2016-04-19T21:34:34Z", + "side": 1, + "message": "Agree. I do not remember what was the reasoning for me to do so, I think I was getting rid of \"global\" config and wanted to make dependency explicit to start with. To make it testable, we would pass the config into __init__ instead of having instance of CIWatchApp in here. Would you like me to update this patch, or do it in the follow up?", + "parentUuid": "1a122d0e_68e470e0", + "revId": "699dae47e3f7e66a0a804c17c996b5d0217c682c", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false } ] } \ No newline at end of file