x/cloudbase-init
Code Issues Proposed changes

Fixed a few pep8 nits

Browse Source
This commit is contained in:
Robert Tingirica
2014-06-11 16:45:22 +03:00
parent bc5eb5f554
commit 184f183311
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cloudbaseinit/osutils/windows.py
View File

@@ -589,7 +589,7 @@ class WindowsUtils(base.BaseOSUtils):
return service.StartMode return service.StartMode
def set_service_start_mode(self, service_name, start_mode): def set_service_start_mode(self, service_name, start_mode):
#TODO(alexpilotti): Handle the "Delayed Start" case # TODO(alexpilotti): Handle the "Delayed Start" case
service = self._get_service(service_name) service = self._get_service(service_name)
(ret_val,) = service.ChangeStartMode(start_mode) (ret_val,) = service.ChangeStartMode(start_mode)
if ret_val != 0: if ret_val != 0:
@@ -806,7 +806,7 @@ class WindowsUtils(base.BaseOSUtils):
try: try:
# NOTE(alexpilotti): the size provided by ctypes.sizeof # NOTE(alexpilotti): the size provided by ctypes.sizeof
# is not the expected one # is not the expected one
#pdidd.contents.cbSize = ctypes.sizeof( # pdidd.contents.cbSize = ctypes.sizeof(
# Win32_SP_DEVICE_INTERFACE_DETAIL_DATA_W) # Win32_SP_DEVICE_INTERFACE_DETAIL_DATA_W)
pdidd.contents.cbSize = 6 pdidd.contents.cbSize = 6

2
cloudbaseinit/plugins/windows/extendvolumes.py
View File

@@ -57,7 +57,7 @@ class ExtendVolumesPlugin(base.BasePlugin):
if volume_idxs is not None: if volume_idxs is not None:
volume_name = ctypes.wstring_at(volume_prop.pwszName) volume_name = ctypes.wstring_at(volume_prop.pwszName)
volume_idx = self._get_volume_index(volume_name) volume_idx = self._get_volume_index(volume_name)
if not volume_idx in volume_idxs: if volume_idx not in volume_idxs:
extend_volume = False extend_volume = False
if extend_volume: if extend_volume:

2
cloudbaseinit/utils/crypt.py
View File

@@ -161,7 +161,7 @@ class CryptManager(object):
key_type = pub_key[offset:offset + key_type_len] key_type = pub_key[offset:offset + key_type_len]
offset += key_type_len offset += key_type_len
if not key_type in ['ssh-rsa', 'rsa', 'rsa1']: if key_type not in ['ssh-rsa', 'rsa', 'rsa1']:
raise CryptException('Unsupported SSH key type "%s". ' raise CryptException('Unsupported SSH key type "%s". '
'Only RSA keys are currently supported' 'Only RSA keys are currently supported'
% key_type) % key_type)