x
/
cloudbase-init
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 36901 \u003c36901@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36901\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9649 \u003c9649@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36901\u003e replied on the change"}
This commit is contained in:
Gerrit User 36901 2024-03-26 04:27:28 +00:00 committed by Gerrit Code Review
parent 641f76c5f7
commit a7184ce7dc
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
8bf9ce6f86a483f632e7cc136d619a0e1fbc3c6f
View File

@ -16,6 +16,24 @@
"message": "Hello Zhongcheng Lao, can you please give more details on why this change was required?",
"revId": "8bf9ce6f86a483f632e7cc136d619a0e1fbc3c6f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "858c06a7_429da451",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 36901
},
"writtenOn": "2024-03-26T04:27:28Z",
"side": 1,
"message": "The code tries to log in as a batch user.\nI don\u0027t see the installer script granted the SeBatchLogonRight right for the created user. Only SeServiceLogonRight is granted by default.\nhttps://github.com/cloudbase/cloudbase-init-installer/blob/a19436cf78d6add1b25a4a21d6141320b31a5f93/CloudbaseInitSetup/Carbon/Service/Install-Service.ps1#L194\nGrant-Privilege -Identity $identity -Privilege SeServiceLogonRight\n\nI\u0027m not sure if it was on purpose to use SeBatchLogonRight other than SeServiceLogonRight.",
"parentUuid": "a5c65adb_f854a65f",
"revId": "8bf9ce6f86a483f632e7cc136d619a0e1fbc3c6f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}