From c71ac192e4d6616a2ea4d9ac70c0dd4cf27fbfd1 Mon Sep 17 00:00:00 2001 From: Cosmin Poieana Date: Wed, 24 Jun 2015 23:30:10 +0300 Subject: [PATCH] Get rid of all __all__ The "from import *" is forbidden and private objects are prefixed with an underscore, so the `__all__` variable won't be necessary. Change-Id: If09af33adba2fc7019e439ec947dc191e03dcc3a --- cloudbaseinit/plugins/common/execcmd.py | 11 ----------- .../common/userdataplugins/cloudconfigplugins/base.py | 5 ----- cloudbaseinit/tests/testutils.py | 8 -------- 3 files changed, 24 deletions(-) diff --git a/cloudbaseinit/plugins/common/execcmd.py b/cloudbaseinit/plugins/common/execcmd.py index e0f0c56a..67ec046c 100644 --- a/cloudbaseinit/plugins/common/execcmd.py +++ b/cloudbaseinit/plugins/common/execcmd.py @@ -23,17 +23,6 @@ from cloudbaseinit.openstack.common import log as logging from cloudbaseinit.osutils import factory as osutils_factory -__all__ = ( - 'BaseCommand', - 'Shell', - 'Python', - 'Bash', - 'Powershell', - 'PowershellSysnative', - 'CommandExecutor', - 'EC2Config', -) - LOG = logging.getLogger(__name__) # used with ec2 config files (xmls) diff --git a/cloudbaseinit/plugins/common/userdataplugins/cloudconfigplugins/base.py b/cloudbaseinit/plugins/common/userdataplugins/cloudconfigplugins/base.py index 9e9d0cb6..4b27f7fc 100644 --- a/cloudbaseinit/plugins/common/userdataplugins/cloudconfigplugins/base.py +++ b/cloudbaseinit/plugins/common/userdataplugins/cloudconfigplugins/base.py @@ -17,11 +17,6 @@ import abc import six -__all__ = ( - 'BaseCloudConfigPlugin', -) - - @six.add_metaclass(abc.ABCMeta) class BaseCloudConfigPlugin(object): """Base plugin class for cloud-config plugins.""" diff --git a/cloudbaseinit/tests/testutils.py b/cloudbaseinit/tests/testutils.py index 2969dab6..d0712658 100644 --- a/cloudbaseinit/tests/testutils.py +++ b/cloudbaseinit/tests/testutils.py @@ -33,14 +33,6 @@ from cloudbaseinit.openstack.common import log as logging CONF = cfg.CONF -__all__ = ( - 'create_tempfile', - 'create_tempdir', - 'LogSnatcher', - 'CloudbaseInitTestBase', - 'ConfPatcher', -) - @contextlib.contextmanager def create_tempdir():