03141359a6
Patch Set 17:
(1 comment)
Patch-set: 17
Attention: {"person_ident":"Gerrit User 36142 \u003c36142@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36142\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 36852 \u003c36852@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36142\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9649 \u003c9649@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36142\u003e replied on the change"}
39 lines
1.1 KiB
Plaintext
39 lines
1.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ece567ba_d168555a",
|
|
"filename": "cloudbaseinit/osutils/windows.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 863,
|
|
"author": {
|
|
"id": 9649
|
|
},
|
|
"writtenOn": "2024-03-05T12:56:33Z",
|
|
"side": 1,
|
|
"message": "If you can throw here the same exception as in the original code.",
|
|
"revId": "1af376a0595ca143c019be4b8a8e8197587889ea",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "70f972b0_cabab302",
|
|
"filename": "cloudbaseinit/osutils/windows.py",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 863,
|
|
"author": {
|
|
"id": 36142
|
|
},
|
|
"writtenOn": "2024-03-21T07:00:47Z",
|
|
"side": 1,
|
|
"message": "As far as i understand put() does not return anything.\nIn case of an exception within put() i moved it to be handeld by the try block we already have.",
|
|
"parentUuid": "ece567ba_d168555a",
|
|
"revId": "1af376a0595ca143c019be4b8a8e8197587889ea",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |