x/clouddocs-maven-plugin
Code Issues Proposed changes

Fix improper string comparisons

Browse Source
This commit is contained in:
Sam Harwell
2013-08-23 07:40:06 -05:00
parent eb15f276f5
commit 3e3e8dca93
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/com/rackspace/cloud/api/docs/builders/PDFBuilder.java
View File

@@ -201,7 +201,7 @@ public class PDFBuilder {
//final String inputFilename = sourceFilePath;
// targetFilename is inputFilename - ".xml" + targetFile extension
String baseTargetFile;
if(null != pdfFilenameBase && pdfFilenameBase != ""){
if(null != pdfFilenameBase && !pdfFilenameBase.isEmpty()){
baseTargetFile = pdfFilenameBase;
} else {
baseTargetFile = inputFilename.substring(0, inputFilename.length() - 4);
@@ -344,7 +344,7 @@ public class PDFBuilder {
transformer.setParameter("autoPdfGlossaryInfix","/..");
transformer.setParameter("branding", branding);
if(branding=="openstack") {
if("openstack".equals(branding)) {
transformer.setParameter("builtForOpenStack", "1");
} else {
transformer.setParameter("builtForOpenStack", "0");