x/cloudroast
Code Issues Proposed changes

Refactor/cleanup for change password tests

Browse Source 
* Added skip for tests based on hypervisor
* Fixed pep8 issues

Change-Id: I77f1f2a55d11d0fe907616d34ba61044acbe58c8
This commit is contained in:
Daryl Walleck
2013-05-15 16:09:02 -05:00
parent a8a867cf7b
commit 3c5462a2e8
1 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
test_repo/compute/functional/servers/actions/test_change_password.py
View File

@@ -14,12 +14,22 @@ See the License for the specific language governing permissions and
limitations under the License.
"""
import unittest2 as unittest
from cafe.drivers.unittest.decorators import tags
from cloudcafe.compute.common.types import ComputeHypervisors
from cloudcafe.compute.common.types import NovaServerStatusTypes as \
ServerStates
from cloudcafe.compute.config import ComputeConfig
from test_repo.compute.fixtures import CreateServerFixture
compute_config = ComputeConfig()
hypervisor = compute_config.hypervisor.lower()
@unittest.skipIf(hypervisor in [ComputeHypervisors.KVM,
ComputeHypervisors.QEMU],
'Change password not supported in current configuration.')
class ChangeServerPasswordTests(CreateServerFixture):
@classmethod
@@ -49,14 +59,15 @@ class ChangeServerPasswordTests(CreateServerFixture):
# Get server details
server = self.servers_client.get_server(self.server.id).entity
# Set the server's adminPass attribute to the new password,vas this field is not set in getServer
# Set the server's admin_pass attribute to the new password
server.admin_pass = self.new_password
public_address = self.server_behaviors.get_public_ip_address(server)
# Get an instance of the remote client
remote_client = self.server_behaviors.get_remote_instance_client(server,
config=self.servers_config)
remote_client = self.server_behaviors.get_remote_instance_client(
server, config=self.servers_config)
self.assertTrue(remote_client.can_connect_to_public_ip(),
"Could not connect to server (%s) using new admin password %s" %
(public_address, self.new_password))
self.assertTrue(
remote_client.can_connect_to_public_ip(),
"Could not connect to server (%s) using new admin password %s" %
(public_address, self.new_password))