Update patch set 1

Patch Set 1:

(1 comment)

Quick comment from Jose. 

Yes, that Jose! He even watches us when he's not here, almost like Santa Claus! ;)

Patch-set: 1
This commit is contained in:
Gerrit User 8969 2018-12-06 23:10:13 +00:00 committed by Gerrit Code Review
parent c022d42310
commit 7b95c03cfc
1 changed files with 21 additions and 0 deletions

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "3f79a3b5_5287350b",
"filename": "cloudroast/blockstorage/volumes_api/snapshots/smoke.py",
"patchSetId": 1
},
"lineNbr": 58,
"author": {
"id": 8969
},
"writtenOn": "2018-12-06T23:10:13Z",
"side": 1,
"message": "I just found out, in the case of complete_volume_types data generators, you can combine the decorators to make things simpler: \n\n@data_driven_test(complete_volume_types(tags\u003d[\u0027smoke\u0027, \u0027positive\u0027])\n\nhttps://github.com/openstack/cloudcafe/blob/master/cloudcafe/blockstorage/datasets.py#L83\n\nThe data generator will automatically add the tags to the test cases.",
"revId": "b21f8ad6ca50762592da8c2d560535e79d6dfaa7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}