Update patch set 14

Patch Set 14: Code-Review-1 (6 comments) Patch-set: 14 Label: Code-Review=-1
2018-10-07 10:03:59 +00:00 · 2018-10-07 10:03:59 +00:00 · 26691dc0c6
parent 6534c43c4d
commit 26691dc0c6
1 changed files with 136 additions and 0 deletions
--- a/136
+++ b/136
@ -0,0 +1,136 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "3f79a3b5_931f8fb7",
+        "filename": ".gitignore",
+        "patchSetId": 14
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 26507
+      },
+      "writtenOn": "2018-10-07T10:03:59Z",
+      "side": 1,
+      "message": "Wow, that\u0027s quite a long .gitignore, are you sure we need that much? \n\nLet\u0027s be minimalists and grow from there.",
+      "revId": "9dd9d1860d7147c6e6be0677d4ef0c83c5191d41",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_93646f4f",
+        "filename": "README.md",
+        "patchSetId": 14
+      },
+      "lineNbr": 11,
+      "author": {
+        "id": 26507
+      },
+      "writtenOn": "2018-10-07T10:03:59Z",
+      "side": 1,
+      "message": "nit: we should put this somewhere else?",
+      "range": {
+        "startLine": 11,
+        "startChar": 22,
+        "endLine": 11,
+        "endChar": 75
+      },
+      "revId": "9dd9d1860d7147c6e6be0677d4ef0c83c5191d41",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_13793ffa",
+        "filename": "README.md",
+        "patchSetId": 14
+      },
+      "lineNbr": 20,
+      "author": {
+        "id": 26507
+      },
+      "writtenOn": "2018-10-07T10:03:59Z",
+      "side": 1,
+      "message": "we will forget to change this. Better put \"run sane checks\" or something like that",
+      "range": {
+        "startLine": 19,
+        "startChar": 51,
+        "endLine": 20,
+        "endChar": 40
+      },
+      "revId": "9dd9d1860d7147c6e6be0677d4ef0c83c5191d41",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_b37debe7",
+        "filename": "bindep.txt",
+        "patchSetId": 14
+      },
+      "lineNbr": 5,
+      "author": {
+        "id": 26507
+      },
+      "writtenOn": "2018-10-07T10:03:59Z",
+      "side": 1,
+      "message": "you put bionic though",
+      "range": {
+        "startLine": 5,
+        "startChar": 31,
+        "endLine": 5,
+        "endChar": 37
+      },
+      "revId": "9dd9d1860d7147c6e6be0677d4ef0c83c5191d41",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_3371db0e",
+        "filename": "cspell.json",
+        "patchSetId": 14
+      },
+      "lineNbr": 6,
+      "author": {
+        "id": 26507
+      },
+      "writtenOn": "2018-10-07T10:03:59Z",
+      "side": 1,
+      "message": "needed?",
+      "range": {
+        "startLine": 5,
+        "startChar": 8,
+        "endLine": 6,
+        "endChar": 16
+      },
+      "revId": "9dd9d1860d7147c6e6be0677d4ef0c83c5191d41",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3f79a3b5_d35bc783",
+        "filename": "setup.cfg",
+        "patchSetId": 14
+      },
+      "lineNbr": 6,
+      "author": {
+        "id": 26507
+      },
+      "writtenOn": "2018-10-07T10:03:59Z",
+      "side": 1,
+      "message": "Checked other openstack projects and they put more generic things here, e.g. https://github.com/openstack/neutron/blob/master/setup.cfg",
+      "range": {
+        "startLine": 3,
+        "startChar": 0,
+        "endLine": 6,
+        "endChar": 42
+      },
+      "revId": "9dd9d1860d7147c6e6be0677d4ef0c83c5191d41",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}