plugin.py is really hard to test because good part of its logic happend during code importation. It's test depends on the base TestCase that mocks too much thinks in a way that makes hard to spot real problems. The test also fails to test re-authenthication bug because of bad mocking. This code should fix above problems. It also remove some logic in the hooks: exceptions are already captured and logged by collectd and there is no need doing it inside of hooks. Init hook is also pointless from the perspective of this plugin initialization and it was removed. Co-authored-by: Emma Foley <emma.l.foley@intel.com> Related-Bug: #1615349 Change-Id: I4db8a94243ecbe98cd6bc13e4b66293172346dcd
510 lines
17 KiB
Python
510 lines
17 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
# Copyright 2010-2011 OpenStack Foundation
|
|
# Copyright (c) 2015 Intel Corporation.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
"""Plugin tests
|
|
|
|
"""
|
|
|
|
from collections import namedtuple
|
|
import logging
|
|
import requests
|
|
import unittest
|
|
|
|
import mock
|
|
|
|
from collectd_ceilometer import keystone_light
|
|
from collectd_ceilometer import plugin
|
|
from collectd_ceilometer import sender
|
|
|
|
from collectd_ceilometer.tests import match
|
|
|
|
|
|
Logger = logging.getLoggerClass()
|
|
|
|
|
|
def mock_collectd(**kwargs):
|
|
"Returns collecd module with collecd logging hooks."
|
|
return mock.patch(
|
|
__name__ + '.' + MockedCollectd.__name__, specs=True,
|
|
get_dataset=mock.MagicMock(side_effect=Exception), **kwargs)
|
|
|
|
|
|
class MockedCollectd(object):
|
|
"Mocked collectd module specifications."
|
|
|
|
def debug(self, record):
|
|
"Hook for debug messages"
|
|
|
|
def info(self, record):
|
|
"Hook for info messages"
|
|
|
|
def warning(self, record):
|
|
"Hook for warning messages"
|
|
|
|
def error(self, record):
|
|
"Hook for error messages"
|
|
|
|
def register_init(self, hook):
|
|
"Register an hook for init."
|
|
|
|
def register_config(self, hook):
|
|
"Register an hook for config."
|
|
|
|
def register_write(self, hook):
|
|
"Register an hook for write."
|
|
|
|
def register_shutdown(self, hook):
|
|
"Register an hook for shutdown."
|
|
|
|
def get_dataset(self, s):
|
|
"Gets a dataset."
|
|
|
|
|
|
def mock_config(BATCH_SIZE=1, **kwargs):
|
|
"Returns collecd module with collecd logging hooks."
|
|
return mock.patch(
|
|
__name__ + '.' + MockedConfig.__name__, specs=True,
|
|
BATCH_SIZE=BATCH_SIZE, **kwargs)
|
|
|
|
|
|
class MockedConfig(object):
|
|
"Mocked config class."
|
|
|
|
BATCH_SIZE = 1
|
|
OS_AUTH_URL = "http://test-url"
|
|
|
|
|
|
def mock_value(
|
|
host='localhost', plugin='cpu', plugin_instance='0',
|
|
_type='freq', type_instance=None, time=123456789, values=(1234,),
|
|
**kwargs):
|
|
"""Create a mock value"""
|
|
|
|
return mock.patch(
|
|
__name__ + '.' + MockedValue.__name__, specs=True,
|
|
host=host, plugin=plugin, plugin_instance=plugin_instance, type=_type,
|
|
type_instance=type_instance, time=time, values=list(values), meta=None,
|
|
**kwargs)
|
|
|
|
|
|
class MockedValue(object):
|
|
"""Value used for testing"""
|
|
|
|
host = 'localhost'
|
|
plugin = None
|
|
plugin_instance = None
|
|
type = None
|
|
type_instance = None
|
|
time = 123456789
|
|
values = []
|
|
meta = None
|
|
|
|
|
|
class TestPlugin(unittest.TestCase):
|
|
"""Test the collectd plugin"""
|
|
|
|
@mock.patch.object(plugin, 'Plugin', autospec=True)
|
|
@mock.patch.object(plugin, 'Config', autospec=True)
|
|
@mock.patch.object(plugin, 'CollectdLogHandler', autospec=True)
|
|
@mock.patch.object(plugin, 'ROOT_LOGGER', autospec=True)
|
|
@mock_collectd()
|
|
def test_callbacks(
|
|
self, collectd, ROOT_LOGGER, CollectdLogHandler, Config, Plugin):
|
|
"""Verify that the callbacks are registered properly"""
|
|
|
|
# When plugin function is called
|
|
plugin.register_plugin(collectd=collectd)
|
|
|
|
# Logger handler is set up
|
|
ROOT_LOGGER.addHandler.assert_called_once_with(
|
|
CollectdLogHandler.return_value)
|
|
ROOT_LOGGER.setLevel.assert_called_once_with(logging.NOTSET)
|
|
|
|
# It create a plugin
|
|
Plugin.assert_called_once_with(
|
|
collectd=collectd, config=Config.instance.return_value)
|
|
|
|
# callbacks are registered to collectd
|
|
instance = Plugin.return_value
|
|
collectd.register_config.assert_called_once_with(instance.config)
|
|
collectd.register_write.assert_called_once_with(instance.write)
|
|
collectd.register_shutdown.assert_called_once_with(instance.shutdown)
|
|
|
|
@mock.patch.object(requests, 'post', spec=callable)
|
|
@mock.patch.object(sender, 'ClientV3', autospec=True)
|
|
@mock_collectd()
|
|
@mock_config(BATCH_SIZE=2)
|
|
@mock_value()
|
|
def test_write(self, data, config, collectd, ClientV3, post):
|
|
"""Test collectd data writing"""
|
|
|
|
auth_client = ClientV3.return_value
|
|
auth_client.get_service_endpoint.return_value =\
|
|
'https://test-ceilometer.tld'
|
|
|
|
post.return_value.status_code = sender.HTTP_CREATED
|
|
post.return_value.text = 'Created'
|
|
|
|
# init instance
|
|
instance = plugin.Plugin(collectd=collectd, config=config)
|
|
|
|
# no authentication has been performed so far
|
|
ClientV3.assert_not_called()
|
|
|
|
# write first value
|
|
instance.write(data)
|
|
collectd.error.assert_not_called()
|
|
|
|
# no value has been sent to ceilometer
|
|
post.assert_not_called()
|
|
|
|
# send the second value
|
|
instance.write(data)
|
|
collectd.error.assert_not_called()
|
|
|
|
# authentication client has been created
|
|
ClientV3.assert_called_once()
|
|
|
|
# and values has been sent
|
|
post.assert_called_once_with(
|
|
'https://test-ceilometer.tld/v2/meters/cpu.freq',
|
|
data=match.json([
|
|
{"source": "collectd",
|
|
"counter_name": "cpu.freq",
|
|
"counter_unit": "jiffies",
|
|
"counter_volume": 1234,
|
|
"timestamp": "Thu Nov 29 21:33:09 1973",
|
|
"resource_id": "localhost-0",
|
|
"resource_metadata": None,
|
|
"counter_type": "gauge"},
|
|
{"source": "collectd",
|
|
"counter_name": "cpu.freq",
|
|
"counter_unit": "jiffies",
|
|
"counter_volume": 1234,
|
|
"timestamp": "Thu Nov 29 21:33:09 1973",
|
|
"resource_id": "localhost-0",
|
|
"resource_metadata": None,
|
|
"counter_type": "gauge"}]),
|
|
headers={'Content-type': 'application/json',
|
|
'X-Auth-Token': auth_client.auth_token},
|
|
timeout=1.0)
|
|
|
|
# reset post method
|
|
post.reset_mock()
|
|
|
|
# write another values
|
|
instance.write(data)
|
|
collectd.error.assert_not_called()
|
|
|
|
# nothing has been sent
|
|
post.assert_not_called()
|
|
|
|
# call shutdown
|
|
instance.shutdown()
|
|
|
|
# no errors
|
|
collectd.error.assert_not_called()
|
|
|
|
# previously written value has been sent
|
|
post.assert_called_once_with(
|
|
'https://test-ceilometer.tld/v2/meters/cpu.freq',
|
|
data=match.json([
|
|
{"source": "collectd",
|
|
"counter_name": "cpu.freq",
|
|
"counter_unit": "jiffies",
|
|
"counter_volume": 1234,
|
|
"timestamp": "Thu Nov 29 21:33:09 1973",
|
|
"resource_id": "localhost-0",
|
|
"resource_metadata": None,
|
|
"counter_type": "gauge"}]),
|
|
headers={
|
|
'Content-type': 'application/json',
|
|
'X-Auth-Token': auth_client.auth_token},
|
|
timeout=1.0)
|
|
|
|
@mock.patch.object(requests, 'post', spec=callable)
|
|
@mock.patch.object(sender, 'ClientV3', autospec=True)
|
|
@mock.patch.object(plugin, 'LOGGER', autospec=True)
|
|
@mock_collectd()
|
|
@mock_config()
|
|
@mock_value()
|
|
def test_write_auth_failed(
|
|
self, data, config, collectd, LOGGER, ClientV3, post):
|
|
"""Test authentication failure"""
|
|
|
|
ClientV3.auth_url = "http://tst-url"
|
|
# tell the auth client to rise an exception
|
|
ClientV3.side_effect = RuntimeError('Test Client() exception')
|
|
|
|
# init instance
|
|
instance = plugin.Plugin(collectd=collectd, config=config)
|
|
|
|
# write the value
|
|
self.assertRaises(RuntimeError, instance.write, data)
|
|
|
|
# no requests method has been called
|
|
post.assert_not_called()
|
|
|
|
@mock.patch.object(requests, 'post', spec=callable)
|
|
@mock.patch.object(sender, 'ClientV3', autospec=True)
|
|
@mock.patch.object(sender, 'LOGGER', autospec=True)
|
|
@mock_collectd()
|
|
@mock_config()
|
|
@mock_value()
|
|
def test_write_auth_failed2(
|
|
self, data, config, collectd, LOGGER, ClientV3, post):
|
|
"""Test authentication failure2"""
|
|
|
|
ClientV3.side_effect = keystone_light.KeystoneException(
|
|
"Missing name 'xxx' in received services",
|
|
"exception",
|
|
"services list")
|
|
|
|
# init instance
|
|
instance = plugin.Plugin(collectd=collectd, config=config)
|
|
|
|
# write the value
|
|
instance.write(data)
|
|
|
|
LOGGER.error.assert_called_once_with(
|
|
"Suspending error logs until successful auth")
|
|
LOGGER.log.assert_called_once_with(
|
|
logging.ERROR, "Authentication error: %s",
|
|
"Missing name 'xxx' in received services\nReason: exception",
|
|
exc_info=0)
|
|
|
|
# no requests method has been called
|
|
post.assert_not_called()
|
|
|
|
@mock.patch.object(requests, 'post', spec=callable)
|
|
@mock.patch.object(sender, 'ClientV3', autospec=True)
|
|
@mock_collectd()
|
|
@mock_config()
|
|
@mock_value()
|
|
def test_request_error(
|
|
self, data, config, collectd, ClientV3, post):
|
|
"""Test error raised by underlying requests module"""
|
|
|
|
# tell POST request to raise an exception
|
|
post.side_effect = requests.RequestException('Test POST exception')
|
|
|
|
# init instance
|
|
instance = plugin.Plugin(collectd=collectd, config=config)
|
|
|
|
# write the value
|
|
self.assertRaises(requests.RequestException, instance.write, data)
|
|
|
|
@mock.patch.object(sender.Sender, '_perform_request', spec=callable)
|
|
@mock.patch.object(requests, 'post', spec=callable)
|
|
@mock.patch.object(sender, 'ClientV3', autospec=True)
|
|
@mock_collectd()
|
|
@mock_config()
|
|
@mock_value()
|
|
def test_reauthentication(self, data, config, collectd,
|
|
ClientV3, post, perf_req):
|
|
"""Test re-authentication"""
|
|
|
|
# response returned on success
|
|
response_ok = requests.Response()
|
|
response_ok.status_code = requests.codes["OK"]
|
|
|
|
# response returned on failure
|
|
response_unauthorized = requests.Response()
|
|
response_unauthorized.status_code = requests.codes["UNAUTHORIZED"]
|
|
|
|
# write the first value with success
|
|
# subsequent call of POST method will fail due to the authentication
|
|
perf_req.return_value = response_ok
|
|
|
|
client = ClientV3.return_value
|
|
client.auth_url = "http://tst-url"
|
|
client.auth_token = 'Test auth token'
|
|
|
|
# init instance
|
|
instance = plugin.Plugin(collectd=collectd, config=config)
|
|
|
|
# write the value
|
|
instance.write(data)
|
|
|
|
# verify the auth token
|
|
perf_req.assert_called_once_with(
|
|
mock.ANY, mock.ANY,
|
|
'Test auth token')
|
|
|
|
# set a new auth token
|
|
client.auth_token = 'New test auth token'
|
|
perf_req.side_effect = \
|
|
[requests.exceptions.HTTPError(response=response_unauthorized),
|
|
response_ok]
|
|
|
|
# write the value
|
|
instance.write(data)
|
|
|
|
# verify the auth token
|
|
perf_req.assert_has_calls([
|
|
mock.call(mock.ANY, mock.ANY,
|
|
'Test auth token'),
|
|
mock.call(mock.ANY, mock.ANY,
|
|
'New test auth token')
|
|
])
|
|
|
|
@mock.patch.object(requests, 'post', spec=callable)
|
|
@mock.patch.object(sender, 'ClientV3', autospec=True)
|
|
@mock.patch.object(plugin, 'LOGGER', autospec=True)
|
|
@mock_collectd()
|
|
@mock_config()
|
|
@mock_value()
|
|
def test_authentication_in_multiple_threads(
|
|
self, data, config, collectd, LOGGER, ClientV3, post):
|
|
"""Test authentication in muliple threads
|
|
|
|
This test simulates the authentication performed from different thread
|
|
after the authentication lock has been acquired. The sender is not
|
|
authenticated, the lock is acquired, the authentication token exists
|
|
(i.e. it has been set by different thread) and it is used.
|
|
"""
|
|
# pylint: disable=protected-access
|
|
|
|
# init instance
|
|
instance = plugin.Plugin(collectd=collectd, config=config)
|
|
|
|
# the sender used by the instance
|
|
sender = instance._writer._sender
|
|
|
|
# create a dummy lock
|
|
class DummyLock(namedtuple('LockBase', ['sender', 'token', 'urlbase'])):
|
|
"""Lock simulation, which sets the auth token when locked"""
|
|
|
|
def __enter__(self, *args, **kwargs):
|
|
# pylint: disable=protected-access
|
|
self.sender._auth_token = self.token
|
|
self.sender._url_base = self.urlbase
|
|
|
|
def __exit__(self, *args, **kwargs):
|
|
pass
|
|
|
|
# replace the sender's lock by the dummy lock
|
|
sender._auth_lock = DummyLock(sender, 'TOKEN', 'URLBASE/%s')
|
|
|
|
# write the value
|
|
instance.write(data)
|
|
|
|
# No errors has been registered
|
|
LOGGER.exception.assert_not_called()
|
|
|
|
# client has not been called at all
|
|
ClientV3.assert_not_called()
|
|
|
|
# verify the auth token
|
|
post.assert_called_once_with(
|
|
'URLBASE/cpu.freq', data=mock.ANY,
|
|
headers={
|
|
'Content-type': 'application/json', 'X-Auth-Token': 'TOKEN'},
|
|
timeout=1.0)
|
|
|
|
@mock.patch.object(requests, 'post', spec=callable)
|
|
@mock.patch.object(sender, 'ClientV3', autospec=True)
|
|
@mock.patch.object(plugin, 'Writer', autospec=True)
|
|
@mock.patch.object(plugin, 'LOGGER', autospec=True)
|
|
@mock_collectd()
|
|
@mock_config()
|
|
@mock_value()
|
|
def test_exceptions(
|
|
self, data, config, collectd, LOGGER, Writer, ClientV3, post):
|
|
"""Test exception raised during write and shutdown"""
|
|
|
|
writer = Writer.return_value
|
|
writer.write.side_effect = ValueError('Test write error')
|
|
writer.flush.side_effect = RuntimeError('Test shutdown error')
|
|
|
|
# init instance
|
|
instance = plugin.Plugin(collectd=collectd, config=config)
|
|
|
|
self.assertRaises(ValueError, instance.write, data)
|
|
self.assertRaises(RuntimeError, instance.shutdown)
|
|
|
|
@mock.patch.object(plugin, 'ROOT_LOGGER', new_callable=Logger, name='me')
|
|
@mock_collectd()
|
|
def test_log_debug_to_collectd(self, collectd, ROOT_LOGGER):
|
|
"""Verify that debug messages are sent to collectd."""
|
|
|
|
plugin.register_plugin(collectd=collectd)
|
|
|
|
# When log messages are produced
|
|
ROOT_LOGGER.debug('some %s', 'noise')
|
|
|
|
# When plugin function is called
|
|
collectd.debug.assert_called_once_with('some noise')
|
|
|
|
@mock.patch.object(plugin, 'ROOT_LOGGER', new_callable=Logger, name='me')
|
|
@mock_collectd()
|
|
def test_log_infos_to_collectd(self, collectd, ROOT_LOGGER):
|
|
"""Verify that the callbacks are registered properly"""
|
|
|
|
plugin.register_plugin(collectd=collectd)
|
|
|
|
# When log messages are produced
|
|
ROOT_LOGGER.info('%d info', 1)
|
|
|
|
# When plugin function is called
|
|
collectd.info.assert_called_once_with('1 info')
|
|
|
|
@mock.patch.object(plugin, 'ROOT_LOGGER', new_callable=Logger, name='me')
|
|
@mock_collectd()
|
|
def test_log_errors_to_collectd(self, collectd, ROOT_LOGGER):
|
|
"""Verify that the callbacks are registered properly"""
|
|
|
|
plugin.register_plugin(collectd=collectd)
|
|
|
|
# When log messages are produced
|
|
ROOT_LOGGER.error('some error')
|
|
|
|
# When plugin function is called
|
|
collectd.error.assert_called_once_with('some error')
|
|
|
|
@mock.patch.object(plugin, 'ROOT_LOGGER', new_callable=Logger, name='me')
|
|
@mock_collectd()
|
|
def test_log_fatal_to_collectd(self, collectd, ROOT_LOGGER):
|
|
"""Verify that the callbacks are registered properly"""
|
|
|
|
plugin.register_plugin(collectd=collectd)
|
|
|
|
# When log messages are produced
|
|
ROOT_LOGGER.fatal('some error')
|
|
|
|
# When plugin function is called
|
|
collectd.error.assert_called_once_with('some error')
|
|
|
|
@mock.patch.object(plugin, 'ROOT_LOGGER', new_callable=Logger, name='me')
|
|
@mock_collectd()
|
|
def test_log_exceptions_to_collectd(self, collectd, ROOT_LOGGER):
|
|
"""Verify that the callbacks are registered properly"""
|
|
|
|
plugin.register_plugin(collectd=collectd)
|
|
|
|
# When exception is logged
|
|
try:
|
|
raise ValueError('some error')
|
|
except ValueError:
|
|
ROOT_LOGGER.exception('got exception')
|
|
|
|
# When main function is called
|
|
collectd.error.assert_called_once_with(
|
|
match.wildcard('got exception\n'
|
|
'Traceback (most recent call last):\n'
|
|
'*'
|
|
'ValueError: some error'))
|