9b25d9c02a
Patch Set 2: Code-Review-1 (2 comments) i18n.py should stay, but there's a nit in signature_utils Patch-set: 2 Reviewer: Gerrit User 8623 <8623@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
98 lines
2.7 KiB
Plaintext
98 lines
2.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "9f436f4f_f638df3b",
|
|
"filename": "cursive/i18n.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 26,
|
|
"author": {
|
|
"id": 24711
|
|
},
|
|
"writtenOn": "2017-08-21T20:18:01Z",
|
|
"side": 1,
|
|
"message": "Do we need this file at all if we\u0027re removing translations? I suppose it could be useful to keep around for non-log translations - would that ever be needed?",
|
|
"range": {
|
|
"startLine": 1,
|
|
"startChar": 0,
|
|
"endLine": 26,
|
|
"endChar": 24
|
|
},
|
|
"revId": "86ce1e2ea435656874624396de0c79a125dc08fe",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f2577a7_4e1ce669",
|
|
"filename": "cursive/i18n.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 26,
|
|
"author": {
|
|
"id": 8623
|
|
},
|
|
"writtenOn": "2017-09-11T20:15:17Z",
|
|
"side": 1,
|
|
"message": "Good thoughts, but this file is still needed. The _L* messages are only for the log messages, but there are still exception messages that use _.",
|
|
"parentUuid": "9f436f4f_f638df3b",
|
|
"range": {
|
|
"startLine": 1,
|
|
"startChar": 0,
|
|
"endLine": 26,
|
|
"endChar": 24
|
|
},
|
|
"revId": "86ce1e2ea435656874624396de0c79a125dc08fe",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9f436f4f_b61b77c8",
|
|
"filename": "cursive/signature_utils.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 321,
|
|
"author": {
|
|
"id": 24711
|
|
},
|
|
"writtenOn": "2017-08-21T20:18:01Z",
|
|
"side": 1,
|
|
"message": "This is still translating the text in msg.",
|
|
"range": {
|
|
"startLine": 321,
|
|
"startChar": 15,
|
|
"endLine": 321,
|
|
"endChar": 16
|
|
},
|
|
"revId": "86ce1e2ea435656874624396de0c79a125dc08fe",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f2577a7_6e38c2d2",
|
|
"filename": "cursive/signature_utils.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 321,
|
|
"author": {
|
|
"id": 8623
|
|
},
|
|
"writtenOn": "2017-09-11T20:15:17Z",
|
|
"side": 1,
|
|
"message": "Agreed, this _ can be removed, but the ones below need to stay.",
|
|
"parentUuid": "9f436f4f_b61b77c8",
|
|
"range": {
|
|
"startLine": 321,
|
|
"startChar": 15,
|
|
"endLine": 321,
|
|
"endChar": 16
|
|
},
|
|
"revId": "86ce1e2ea435656874624396de0c79a125dc08fe",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |