x/deb-oslo.log
Code Issues Proposed changes

Make remove_in=0 (no removal) use a better syntax

Browse Source 
Support remove_in=None to indicate no removal instead of remove_in=0
which is not clear when reading through code consuming the deprecated
decorator.

Change-Id: I97c02a5b5cd3b1fc6a71dc11c45414e0fbe4ef11
This commit is contained in:
Morgan Fainberg
2015-03-26 17:13:35 -07:00
parent e9a11f4efd
commit 36c925e95b
2 changed files with 23 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
oslo_log/tests/unit/test_versionutils.py
View File

@@ -175,6 +175,20 @@ class DeprecatedTestCase(test_base.BaseTestCase):
as_of='Grizzly',
remove_in='Grizzly')
@mock.patch('oslo_log.versionutils.report_deprecated_feature')
def test_deprecated_with_removed_none(self, mock_reporter):
@versionutils.deprecated(as_of=versionutils.deprecated.GRIZZLY,
remove_in=None)
def do_outdated_stuff():
return
do_outdated_stuff()
self.assert_deprecated(mock_reporter,
no_removal=True,
what='do_outdated_stuff()',
as_of='Grizzly',
remove_in='Grizzly')
@mock.patch('oslo_log.versionutils.report_deprecated_feature')
def test_deprecated_with_removed_zero_and_alternative(self, mock_reporter):
@versionutils.deprecated(as_of=versionutils.deprecated.GRIZZLY,