x/deb-oslo.log
Code Issues Proposed changes

Merge "Remove is_compatible from versionutils"

Browse Source
This commit is contained in:
Jenkins
2015-05-13 10:05:44 +00:00
committed by Gerrit Code Review
parent 36c925e95b 37166ac6fa
commit 40ad647f1d
2 changed files with 0 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
oslo_log/tests/unit/test_versionutils.py
View File

@@ -312,54 +312,3 @@ class DeprecatedTestCase(test_base.BaseTestCase):
pass
mock_log.assert_not_called()
class IsCompatibleTestCase(test_base.BaseTestCase):
def test_same_version(self):
self.assertTrue(versionutils.is_compatible('1', '1'))
self.assertTrue(versionutils.is_compatible('1.0', '1.0'))
self.assertTrue(versionutils.is_compatible('1.0.0', '1.0.0'))
def test_requested_minor_greater(self):
self.assertFalse(versionutils.is_compatible('1.1', '1.0'))
def test_requested_minor_less_than(self):
self.assertTrue(versionutils.is_compatible('1.0', '1.1'))
def test_requested_patch_greater(self):
self.assertFalse(versionutils.is_compatible('1.0.1', '1.0.0'))
def test_requested_patch_less_than(self):
self.assertTrue(versionutils.is_compatible('1.0.0', '1.0.1'))
def test_requested_patch_not_present_same(self):
self.assertTrue(versionutils.is_compatible('1.0', '1.0.0'))
def test_requested_patch_not_present_less_than(self):
self.assertTrue(versionutils.is_compatible('1.0', '1.0.1'))
def test_current_patch_not_present_same(self):
self.assertTrue(versionutils.is_compatible('1.0.0', '1.0'))
def test_current_patch_not_present_less_than(self):
self.assertFalse(versionutils.is_compatible('1.0.1', '1.0'))
def test_same_major_true(self):
"""Even though the current version is 2.0, since `same_major` defaults
to `True`, 1.0 is deemed incompatible.
"""
self.assertFalse(versionutils.is_compatible('2.0', '1.0'))
self.assertTrue(versionutils.is_compatible('1.0', '1.0'))
self.assertFalse(versionutils.is_compatible('1.0', '2.0'))
def test_same_major_false(self):
"""With `same_major` set to False, then major version compatibiity
rule is not enforced, so a current version of 2.0 is deemed to satisfy
a requirement of 1.0.
"""
self.assertFalse(versionutils.is_compatible('2.0', '1.0',
same_major=False))
self.assertTrue(versionutils.is_compatible('1.0', '1.0',
same_major=False))
self.assertTrue(versionutils.is_compatible('1.0', '2.0',
same_major=False))