From 3201673322dc8b258be454d25521c55007bbbf1f Mon Sep 17 00:00:00 2001 From: Ken'ichi Ohmichi Date: Sun, 6 Dec 2015 05:18:46 +0000 Subject: [PATCH] Fix the links to api-site doc The api-site doc contained invalid links which were duplicated in the doc. We did put TODOs for fixing the links after the api-site changes. Now these links have been fixed on the api-site, so this patch fixes them in tempest-lib. Change-Id: I8bbfc2933d5400b8ae35331bc63f128421486d02 --- tempest_lib/services/compute/aggregates_client.py | 6 +----- tempest_lib/services/compute/flavors_client.py | 6 +----- .../compute/security_group_default_rules_client.py | 8 ++------ 3 files changed, 4 insertions(+), 16 deletions(-) diff --git a/tempest_lib/services/compute/aggregates_client.py b/tempest_lib/services/compute/aggregates_client.py index 75489fe..a90c338 100644 --- a/tempest_lib/services/compute/aggregates_client.py +++ b/tempest_lib/services/compute/aggregates_client.py @@ -97,12 +97,8 @@ class AggregatesClient(rest_client.RestClient): """Remove a host from the given aggregate. Available params: see http://developer.openstack.org/ - api-ref-compute-v2.1.html#removeaggregate + api-ref-compute-v2.1.html#removehost """ - # TODO(oomichi): We can see the API doc of the above method with - # the above link, but the link is wrong because the link is not for - # host api. That is api-site problem. After fixing api-site, we will - # fix the above link also. post_body = json.dumps({'remove_host': kwargs}) resp, body = self.post('os-aggregates/%s/action' % aggregate_id, post_body) diff --git a/tempest_lib/services/compute/flavors_client.py b/tempest_lib/services/compute/flavors_client.py index a5a05d9..7e8eda6 100644 --- a/tempest_lib/services/compute/flavors_client.py +++ b/tempest_lib/services/compute/flavors_client.py @@ -90,12 +90,8 @@ class FlavorsClient(rest_client.RestClient): """Set extra Specs to the mentioned flavor. Available params: see http://developer.openstack.org/ - api-ref-compute-v2.1.html#updateflavor + api-ref-compute-v2.1.html#updateFlavorExtraSpec """ - # TODO(oomichi): We can see the API doc of the above method with - # the above link, but the link is wrong because the link is not for - # flavor-extraspac api. That is api-site problem. - # After fixing api-site, we will fix the above link also. post_body = json.dumps({'extra_specs': kwargs}) resp, body = self.post('flavors/%s/os-extra_specs' % flavor_id, post_body) diff --git a/tempest_lib/services/compute/security_group_default_rules_client.py b/tempest_lib/services/compute/security_group_default_rules_client.py index 62e29d1..74a99b3 100644 --- a/tempest_lib/services/compute/security_group_default_rules_client.py +++ b/tempest_lib/services/compute/security_group_default_rules_client.py @@ -26,13 +26,9 @@ class SecurityGroupDefaultRulesClient(rest_client.RestClient): """Create security group default rule. Available params: see http://developer.openstack.org/ - api-ref-compute-v2.1.html#createSecGroupRule + api-ref-compute-v2.1.html + #createSecGroupDefaultRule """ - # TODO(oomichi): We can see the API doc of the above method with - # the above link, but the link is wrong because the link doesn't - # contain "Default" and the link is duplicated to non default sg. - # After fixing api-site, we will fix the above link also. - # LP: https://bugs.launchpad.net/openstack-api-site/+bug/1521826 post_body = json.dumps({'security_group_default_rule': kwargs}) url = 'os-security-group-default-rules' resp, body = self.post(url, post_body)