x/deb-python-tempest-lib
Code Issues Proposed changes

Revert "Adding support for neutron-debug CLI."

Browse Source 
There isn't a reason to have a function to call this command
live in tempest-lib. The neutron-debug CLI is only used for
local debug and isn't actually a client. It's for running
locally on the same node as neutron. It's completely out of
scope for living in tempest-lib. Just because there is a
CLI for something in an OpenStack project running doesn't
mean we need to have a dedicated function to call it. It's
a simple matter to locally subclass the CLIClient class and
add local functions to call commands for a particular test
suite. 

So let's revert this before it's included in a release. If
it were to be included in a release the effort to remove it
goes up quite a bit, because we need a proper deprecation
cycle.

This reverts commit 43c45b2b9d.

Change-Id: I8e77dd92abd482e6cdbaceff81dc12b9f224e2ec
This commit is contained in:
Matthew Treinish
2015-06-23 14:19:12 +00:00
parent 43c45b2b9d
commit 9aeafe9f5e
1 changed files with 0 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tempest_lib/cli/base.py
View File

@@ -285,29 +285,6 @@ class CLIClient(object):
return self.cmd_with_auth( return self.cmd_with_auth(
'neutron', action, flags, params, fail_ok, merge_stderr) 'neutron', action, flags, params, fail_ok, merge_stderr)
def neutron_debug(self, action, flags='', params='', fail_ok=False,
endpoint_type='publicURL', merge_stderr=False):
"""Executes neutron-debug command for the given action.
:param action: the cli command to run using neutron
:type action: string
:param flags: any optional cli flags to use
:type flags: string
:param params: any optional positional args to use
:type params: string
:param fail_ok: if True an exception is not raised when the
cli return code is non-zero
:type fail_ok: boolean
:param endpoint_type: the type of endpoint for the service
:type endpoint_type: string
:param merge_stderr: if True the stderr buffer is merged into stdout
:type merge_stderr: boolean
"""
return execute(
'neutron-debug', action, flags, params, fail_ok, merge_stderr,
self.cli_dir)
def sahara(self, action, flags='', params='', def sahara(self, action, flags='', params='',
fail_ok=False, endpoint_type='publicURL', merge_stderr=True): fail_ok=False, endpoint_type='publicURL', merge_stderr=True):
"""Executes sahara command for the given action. """Executes sahara command for the given action.