x/deb-python-tempest-lib
Code Issues Proposed changes

Add in a more verbose exception message

Browse Source 
Add in a more verbose message to include credential
username, password, and tenant_name when an invalid
credential exception is raised.

Co-Authored-By: Matthew Treinish <mtreinish@kortar.org>

Change-Id: I8133eb68303eae7492734ad5ea77cf5474a8263f
This commit is contained in:
Arkadiy Kraminsky
2015-09-09 21:55:05 +00:00
committed by Matthew Treinish
parent 307df12b98
commit d51fa191b2
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tempest_lib/auth.py
View File

@@ -43,7 +43,18 @@ class AuthProvider(object):
if self.check_credentials(credentials):
self.credentials = credentials
else:
raise TypeError("Invalid credentials")
if isinstance(credentials, Credentials):
password = credentials.get('password')
message = "Credentials are: " + str(credentials)
if password is None:
message += " Password is not defined."
else:
message += " Password is defined."
raise exceptions.InvalidCredentials(message)
else:
raise TypeError("credentials object is of type %s, which is"
" not a valid Credentials object type." %
credentials.__class__.__name__)
self.cache = None
self.alt_auth_data = None
self.alt_part = None
@@ -521,7 +532,8 @@ class Credentials(object):
def __str__(self):
"""Represent only attributes included in self.ATTRIBUTES"""
_repr = dict((k, getattr(self, k)) for k in self.ATTRIBUTES)
attrs = [attr for attr in self.ATTRIBUTES if attr is not 'password']
_repr = dict((k, getattr(self, k)) for k in attrs)
return str(_repr)
def __eq__(self, other):