x
/
devstack-plugin-libvirt-qemu
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
This commit is contained in:
Gerrit User 11604 2019-11-09 14:19:45 +00:00 committed by Gerrit Code Review
parent 1feac5a3b8
commit eb4c523ab8
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
93c26e5e1b44bcb266b13f7ff801b628f84d5a55
View File

@ -39,6 +39,24 @@
"revId": "93c26e5e1b44bcb266b13f7ff801b628f84d5a55",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_8e42f1aa",
"filename": "devstack/libs/libvirt",
"patchSetId": 3
},
"lineNbr": 225,
"author": {
"id": 11604
},
"writtenOn": "2019-11-09T14:19:45Z",
"side": 1,
"message": "well LIBVRIT_BRANCH can be a random git commit so that wont always work. well i guess it depends on how you write teh extract_version_from function. but yes i see what you are suggesting.\n\ni was considering adding support to install libvirt-python from git too and defaulting to master unless your libvirt branch looked like a tag in which case we would use it.\n\npip_install_gr is proably wrong for other resasons too in this case so ill drop this todo. but i definetly think this can be inproved. for what its worth before we made this public the plugin used to install libvirt python form git but we removed that for some reason when we created the repo.",
"parentUuid": "3fa7e38b_4bedddb5",
"revId": "93c26e5e1b44bcb266b13f7ff801b628f84d5a55",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}