Update patch set 1

Patch Set 1:

(4 comments)

Patch-set: 1
This commit is contained in:
Gerrit User 15834 2019-01-29 09:31:44 +00:00 committed by Gerrit Code Review
parent 9fa8392a85
commit 0ad727bda0
1 changed files with 90 additions and 0 deletions

View File

@ -23,6 +23,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_6185e6ce",
"filename": "fenix/db/sqlalchemy/api.py",
"patchSetId": 1
},
"lineNbr": 203,
"author": {
"id": 15834
},
"writtenOn": "2019-01-29T09:31:44Z",
"side": 1,
"message": "Yes, makes sense",
"parentUuid": "9fdfeff1_7b327312",
"range": {
"startLine": 203,
"startChar": 4,
"endLine": 203,
"endChar": 15
},
"revId": "eb1385d8732a19c96729a4ee5084826642723978",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_9b371700",
@ -46,6 +70,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_016e5a2e",
"filename": "fenix/db/sqlalchemy/api.py",
"patchSetId": 1
},
"lineNbr": 208,
"author": {
"id": 15834
},
"writtenOn": "2019-01-29T09:31:44Z",
"side": 1,
"message": "yep",
"parentUuid": "9fdfeff1_9b371700",
"range": {
"startLine": 208,
"startChar": 4,
"endLine": 208,
"endChar": 14
},
"revId": "eb1385d8732a19c96729a4ee5084826642723978",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_1e68f5b6",
@ -63,6 +111,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_01dc1ae2",
"filename": "fenix/db/sqlalchemy/models.py",
"patchSetId": 1
},
"lineNbr": 65,
"author": {
"id": 15834
},
"writtenOn": "2019-01-29T09:31:44Z",
"side": 1,
"message": "Yes, this table remains a store for action plugins given as input. If we want to make the feature later on to continue a failed session, the DB contains the plugins needed (or like switching over Fenix to another node during a maintenance session)",
"parentUuid": "9fdfeff1_1e68f5b6",
"revId": "eb1385d8732a19c96729a4ee5084826642723978",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_fe41713a",
@ -85,6 +151,30 @@
"revId": "eb1385d8732a19c96729a4ee5084826642723978",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_a4051c13",
"filename": "fenix/db/sqlalchemy/models.py",
"patchSetId": 1
},
"lineNbr": 86,
"author": {
"id": 15834
},
"writtenOn": "2019-01-29T09:31:44Z",
"side": 1,
"message": "This was the dilemma. the action_plugins table is store for different action plugins. It doesn\u0027t work if you have several instances of the same plugin running. One solution would have been then an action_plugin_instances table. Surely it mostly should only have a state as an informal column (to indicate where it possibly failed). Maybe should add this then?",
"parentUuid": "9fdfeff1_fe41713a",
"range": {
"startLine": 85,
"startChar": 0,
"endLine": 86,
"endChar": 65
},
"revId": "eb1385d8732a19c96729a4ee5084826642723978",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}