x
/
fenix
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(6 comments)

Thanks Gergo!

Patch-set: 2
This commit is contained in:
Gerrit User 15834 2020-01-13 09:38:19 +00:00 committed by Gerrit Code Review
parent 69c7f32251
commit 14c63f3f08
1 changed files with 143 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

143
3e40df441973ccef18739bd567f6948720592a09
View File

@ -23,6 +23,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_7961ab10",
"filename": "doc/source/api-ref/v1/parameters.yaml",
"patchSetId": 2
},
"lineNbr": 74,
"author": {
"id": 15834
},
"writtenOn": "2020-01-13T09:38:19Z",
"side": 1,
"message": "Seems like some copy/paste mistake, have to check",
"parentUuid": "3fa7e38b_0774e2ce",
"range": {
"startLine": 74,
"startChar": 0,
"endLine": 74,
"endChar": 7
},
"revId": "3e40df441973ccef18739bd567f6948720592a09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_47665a2a",
@ -46,6 +70,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_19b19792",
"filename": "doc/source/api-ref/v1/parameters.yaml",
"patchSetId": 2
},
"lineNbr": 83,
"author": {
"id": 15834
},
"writtenOn": "2020-01-13T09:38:19Z",
"side": 1,
"message": "thanks",
"parentUuid": "3fa7e38b_47665a2a",
"range": {
"startLine": 83,
"startChar": 60,
"endLine": 83,
"endChar": 64
},
"revId": "3e40df441973ccef18739bd567f6948720592a09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_8749b28e",
@ -69,6 +117,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_79bc4b6b",
"filename": "doc/source/api-ref/v1/parameters.yaml",
"patchSetId": 2
},
"lineNbr": 112,
"author": {
"id": 15834
},
"writtenOn": "2020-01-13T09:38:19Z",
"side": 1,
"message": "thanks",
"parentUuid": "3fa7e38b_8749b28e",
"range": {
"startLine": 112,
"startChar": 60,
"endLine": 112,
"endChar": 64
},
"revId": "3e40df441973ccef18739bd567f6948720592a09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_47341afa",
@ -92,6 +164,53 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_f9f91b4f",
"filename": "doc/source/api-ref/v1/parameters.yaml",
"patchSetId": 2
},
"lineNbr": 133,
"author": {
"id": 15834
},
"writtenOn": "2020-01-13T09:38:19Z",
"side": 1,
"message": "Yes, I have to check the wording in other places too. It is used right in code but incorrectly said here. So when Fenix asks for migration_type operation from VNFM, this is how long it waits for an answer.",
"parentUuid": "3fa7e38b_47341afa",
"range": {
"startLine": 133,
"startChar": 28,
"endLine": 133,
"endChar": 58
},
"revId": "3e40df441973ccef18739bd567f6948720592a09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_794a0b83",
"filename": "doc/source/specifications/ussuri-etsi-feat03.rst",
"patchSetId": 2
},
"lineNbr": 171,
"author": {
"id": 15834
},
"writtenOn": "2020-01-13T09:38:19Z",
"side": 1,
"message": "This too",
"range": {
"startLine": 171,
"startChar": 0,
"endLine": 171,
"endChar": 4
},
"revId": "3e40df441973ccef18739bd567f6948720592a09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_19a7660b",
@ -114,6 +233,30 @@
"revId": "3e40df441973ccef18739bd567f6948720592a09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_997907c8",
"filename": "doc/source/specifications/ussuri-etsi-feat03.rst",
"patchSetId": 2
},
"lineNbr": 213,
"author": {
"id": 15834
},
"writtenOn": "2020-01-13T09:38:19Z",
"side": 1,
"message": "Thanks",
"parentUuid": "3fa7e38b_19a7660b",
"range": {
"startLine": 213,
"startChar": 28,
"endLine": 213,
"endChar": 36
},
"revId": "3e40df441973ccef18739bd567f6948720592a09",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}