x
/
fenix
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(6 comments)

Patch-set: 1
Label: Workflow=0
This commit is contained in:
Gerrit User 27068 2019-04-09 04:59:47 +00:00 committed by Gerrit Code Review
parent 9cb1bdd9f9
commit 56bcf8a4ff
1 changed files with 139 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

139
0c6183b8c19d365f8a299bb94a1c8beb3c74e502
View File

@ -1,5 +1,28 @@
{
"comments": [
{
"key": {
"uuid": "5fc1f717_24da2d4a",
"filename": "fenix/workflow/actions/dummy.py",
"patchSetId": 1
},
"lineNbr": 35,
"author": {
"id": 27068
},
"writtenOn": "2019-04-09T04:59:47Z",
"side": 1,
"message": "This is only for debugging purposes, I guess. Could it be expensive in production?",
"range": {
"startLine": 32,
"startChar": 0,
"endLine": 35,
"endChar": 66
},
"revId": "0c6183b8c19d365f8a299bb94a1c8beb3c74e502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_64bd95d6",
@ -23,6 +46,29 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_15ec4af2",
"filename": "fenix/workflow/workflow.py",
"patchSetId": 1
},
"lineNbr": 93,
"author": {
"id": 27068
},
"writtenOn": "2019-04-09T04:59:47Z",
"side": 1,
"message": "I don\u0027t understand this. Why did you assign different values for self.notif_proj[project_id]?",
"range": {
"startLine": 87,
"startChar": 1,
"endLine": 93,
"endChar": 74
},
"revId": "0c6183b8c19d365f8a299bb94a1c8beb3c74e502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_44b659fb",
@ -46,6 +92,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_95d83a52",
"filename": "fenix/workflow/workflow.py",
"patchSetId": 1
},
"lineNbr": 440,
"author": {
"id": 27068
},
"writtenOn": "2019-04-09T04:59:47Z",
"side": 1,
"message": "+1",
"parentUuid": "5fc1f717_44b659fb",
"range": {
"startLine": 439,
"startChar": 0,
"endLine": 440,
"endChar": 23
},
"revId": "0c6183b8c19d365f8a299bb94a1c8beb3c74e502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_047a9122",
@ -69,6 +139,75 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_d5bb22e2",
"filename": "fenix/workflow/workflows/default.py",
"patchSetId": 1
},
"lineNbr": 65,
"author": {
"id": 27068
},
"writtenOn": "2019-04-09T04:59:47Z",
"side": 1,
"message": "controller_hostnames",
"range": {
"startLine": 65,
"startChar": 8,
"endLine": 65,
"endChar": 17
},
"revId": "0c6183b8c19d365f8a299bb94a1c8beb3c74e502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_f5c09e52",
"filename": "fenix/workflow/workflows/default.py",
"patchSetId": 1
},
"lineNbr": 70,
"author": {
"id": 27068
},
"writtenOn": "2019-04-09T04:59:47Z",
"side": 1,
"message": "controller_hostnames",
"range": {
"startLine": 70,
"startChar": 31,
"endLine": 70,
"endChar": 51
},
"revId": "0c6183b8c19d365f8a299bb94a1c8beb3c74e502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_95b11a04",
"filename": "fenix/workflow/workflows/default.py",
"patchSetId": 1
},
"lineNbr": 73,
"author": {
"id": 27068
},
"writtenOn": "2019-04-09T04:59:47Z",
"side": 1,
"message": "controller_hostnames",
"range": {
"startLine": 73,
"startChar": 12,
"endLine": 73,
"endChar": 32
},
"revId": "0c6183b8c19d365f8a299bb94a1c8beb3c74e502",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5fc1f717_8493e14e",