x
/
fenix
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(12 comments)

Thanks again for the great review.

Patch-set: 5
This commit is contained in:
Gerrit User 15834 2019-06-26 10:30:45 +00:00 committed by Gerrit Code Review
parent 718217e677
commit 75644f8533
1 changed files with 288 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

288
dd11fc5a0cab356ef3dc1d6329887b76d77346d3
View File

@ -23,6 +23,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_999ac711",
"filename": "fenix/api/context.py",
"patchSetId": 5
},
"lineNbr": 34,
"author": {
"id": 15834
},
"writtenOn": "2019-06-26T10:30:45Z",
"side": 1,
"message": "Thanks, I need to revisit all these",
"parentUuid": "9fb8cfa7_172a252b",
"range": {
"startLine": 31,
"startChar": 0,
"endLine": 34,
"endChar": 22
},
"revId": "dd11fc5a0cab356ef3dc1d6329887b76d77346d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_b7223951",
@ -46,6 +70,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_399b9b17",
"filename": "fenix/api/context.py",
"patchSetId": 5
},
"lineNbr": 38,
"author": {
"id": 15834
},
"writtenOn": "2019-06-26T10:30:45Z",
"side": 1,
"message": "Thanks, I need to revisit all these",
"parentUuid": "9fb8cfa7_b7223951",
"range": {
"startLine": 35,
"startChar": 0,
"endLine": 38,
"endChar": 25
},
"revId": "dd11fc5a0cab356ef3dc1d6329887b76d77346d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_9715b5e7",
@ -69,6 +117,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_59a0cf42",
"filename": "fenix/api/context.py",
"patchSetId": 5
},
"lineNbr": 42,
"author": {
"id": 15834
},
"writtenOn": "2019-06-26T10:30:45Z",
"side": 1,
"message": "Thanks, I need to revisit all these",
"parentUuid": "9fb8cfa7_9715b5e7",
"range": {
"startLine": 39,
"startChar": 0,
"endLine": 42,
"endChar": 25
},
"revId": "dd11fc5a0cab356ef3dc1d6329887b76d77346d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_57d97d54",
@ -92,6 +164,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_f988a3c6",
"filename": "fenix/api/context.py",
"patchSetId": 5
},
"lineNbr": 46,
"author": {
"id": 15834
},
"writtenOn": "2019-06-26T10:30:45Z",
"side": 1,
"message": "Thanks, I need to revisit all these",
"parentUuid": "9fb8cfa7_57d97d54",
"range": {
"startLine": 43,
"startChar": 1,
"endLine": 46,
"endChar": 24
},
"revId": "dd11fc5a0cab356ef3dc1d6329887b76d77346d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_17df853a",
@ -115,6 +211,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_b98eabce",
"filename": "fenix/api/context.py",
"patchSetId": 5
},
"lineNbr": 50,
"author": {
"id": 15834
},
"writtenOn": "2019-06-26T10:30:45Z",
"side": 1,
"message": "Thanks, I need to revisit all these",
"parentUuid": "9fb8cfa7_17df853a",
"range": {
"startLine": 47,
"startChar": 0,
"endLine": 50,
"endChar": 27
},
"revId": "dd11fc5a0cab356ef3dc1d6329887b76d77346d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_b7e79912",
@ -138,6 +258,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_79bef365",
"filename": "fenix/api/context.py",
"patchSetId": 5
},
"lineNbr": 54,
"author": {
"id": 15834
},
"writtenOn": "2019-06-26T10:30:45Z",
"side": 1,
"message": "Thanks, my copy/paste bad",
"parentUuid": "9fb8cfa7_b7e79912",
"range": {
"startLine": 51,
"startChar": 0,
"endLine": 54,
"endChar": 27
},
"revId": "dd11fc5a0cab356ef3dc1d6329887b76d77346d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_f7a751bb",
@ -161,6 +305,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_f9b18390",
"filename": "fenix/api/context.py",
"patchSetId": 5
},
"lineNbr": 58,
"author": {
"id": 15834
},
"writtenOn": "2019-06-26T10:30:45Z",
"side": 1,
"message": "Thanks",
"parentUuid": "9fb8cfa7_f7a751bb",
"range": {
"startLine": 55,
"startChar": 0,
"endLine": 58,
"endChar": 20
},
"revId": "dd11fc5a0cab356ef3dc1d6329887b76d77346d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_378ba91f",
@ -184,6 +352,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_9c2dd596",
"filename": "fenix/api/root.py",
"patchSetId": 5
},
"lineNbr": 35,
"author": {
"id": 15834
},
"writtenOn": "2019-06-26T10:30:45Z",
"side": 1,
"message": "ok, so I have looked example with more that one version while we only have one. Actually, this seems correct behavior as at least heat also have 300, while returns list with only one version. So the result is always a list of versions while you would only have one.",
"parentUuid": "9fb8cfa7_378ba91f",
"range": {
"startLine": 35,
"startChar": 37,
"endLine": 35,
"endChar": 40
},
"revId": "dd11fc5a0cab356ef3dc1d6329887b76d77346d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_b789d9ca",
@ -207,6 +399,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_3ca149f8",
"filename": "fenix/api/v1/controllers/maintenance.py",
"patchSetId": 5
},
"lineNbr": 125,
"author": {
"id": 15834
},
"writtenOn": "2019-06-26T10:30:45Z",
"side": 1,
"message": "admin_create_session will only return currently None in this case, so this is ok. Surely it is another story to have all \"engine\"/workflow side \"exceptions\" with a better error message to API response.",
"parentUuid": "9fb8cfa7_b789d9ca",
"range": {
"startLine": 125,
"startChar": 30,
"endLine": 125,
"endChar": 33
},
"revId": "dd11fc5a0cab356ef3dc1d6329887b76d77346d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_17ba256d",
@ -230,6 +446,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_7c37c1b1",
"filename": "fenix/cmd/api.py",
"patchSetId": 5
},
"lineNbr": 20,
"author": {
"id": 15834
},
"writtenOn": "2019-06-26T10:30:45Z",
"side": 1,
"message": "Happily followed the way other projects have done. I guess the wsgiref we had would have been fine? I have not followed any discussions",
"parentUuid": "9fb8cfa7_17ba256d",
"range": {
"startLine": 16,
"startChar": 0,
"endLine": 20,
"endChar": 14
},
"revId": "dd11fc5a0cab356ef3dc1d6329887b76d77346d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_176f85fc",
@ -253,6 +493,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_1901f738",
"filename": "fenix/exceptions.py",
"patchSetId": 5
},
"lineNbr": 72,
"author": {
"id": 15834
},
"writtenOn": "2019-06-26T10:30:45Z",
"side": 1,
"message": "500 is default in FenixException, but PolicyNotAuthorized and ServiceCatalogNotFound do not inherit straight that and have a different response.",
"parentUuid": "9fb8cfa7_176f85fc",
"range": {
"startLine": 63,
"startChar": 0,
"endLine": 72,
"endChar": 43
},
"revId": "dd11fc5a0cab356ef3dc1d6329887b76d77346d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_7756012d",
@ -275,6 +539,30 @@
"revId": "dd11fc5a0cab356ef3dc1d6329887b76d77346d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_9c3cf593",
"filename": "fenix/policy.py",
"patchSetId": 5
},
"lineNbr": 18,
"author": {
"id": 15834
},
"writtenOn": "2019-06-26T10:30:45Z",
"side": 1,
"message": "Thanks",
"parentUuid": "9fb8cfa7_7756012d",
"range": {
"startLine": 18,
"startChar": 7,
"endLine": 18,
"endChar": 16
},
"revId": "dd11fc5a0cab356ef3dc1d6329887b76d77346d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}