Update patch set 1

Patch Set 1: (5 comments) Some explaining if not obvious. Patch-set: 1
2019-03-29 08:15:22 +00:00 · 2019-03-29 08:15:22 +00:00 · 9cb1bdd9f9
parent 41533aaa2f
commit 9cb1bdd9f9
1 changed files with 119 additions and 0 deletions
--- a/119
+++ b/119
@ -0,0 +1,119 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "5fc1f717_64bd95d6",
+        "filename": "fenix/workflow/workflow.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 93,
+      "author": {
+        "id": 15834
+      },
+      "writtenOn": "2019-03-29T08:15:22Z",
+      "side": 1,
+      "message": "some problems with alarms with multitenancy and thus made this separate for each project",
+      "range": {
+        "startLine": 85,
+        "startChar": 0,
+        "endLine": 93,
+        "endChar": 74
+      },
+      "revId": "0c6183b8c19d365f8a299bb94a1c8beb3c74e502",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5fc1f717_44b659fb",
+        "filename": "fenix/workflow/workflow.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 440,
+      "author": {
+        "id": 15834
+      },
+      "writtenOn": "2019-03-29T08:15:22Z",
+      "side": 1,
+      "message": "This can be removed",
+      "range": {
+        "startLine": 439,
+        "startChar": 0,
+        "endLine": 440,
+        "endChar": 23
+      },
+      "revId": "0c6183b8c19d365f8a299bb94a1c8beb3c74e502",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5fc1f717_047a9122",
+        "filename": "fenix/workflow/workflows/default.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 65,
+      "author": {
+        "id": 15834
+      },
+      "writtenOn": "2019-03-29T08:15:22Z",
+      "side": 1,
+      "message": "There might be more than one service instance on host, so do not handle twice",
+      "range": {
+        "startLine": 65,
+        "startChar": 8,
+        "endLine": 65,
+        "endChar": 33
+      },
+      "revId": "0c6183b8c19d365f8a299bb94a1c8beb3c74e502",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5fc1f717_8493e14e",
+        "filename": "fenix/workflow/workflows/default.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 613,
+      "author": {
+        "id": 15834
+      },
+      "writtenOn": "2019-03-29T08:15:22Z",
+      "side": 1,
+      "message": "instance.host needs to be consistent",
+      "range": {
+        "startLine": 613,
+        "startChar": 24,
+        "endLine": 613,
+        "endChar": 44
+      },
+      "revId": "0c6183b8c19d365f8a299bb94a1c8beb3c74e502",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5fc1f717_e4cc256b",
+        "filename": "fenix/workflow/workflows/default.py",
+        "patchSetId": 1
+      },
+      "lineNbr": 790,
+      "author": {
+        "id": 15834
+      },
+      "writtenOn": "2019-03-29T08:15:22Z",
+      "side": 1,
+      "message": "For now we do all controllers here. To minimize some downtime this might need to be more optimized later if the wisdom to minimize something like networking downtime cannot be put to action plugins",
+      "range": {
+        "startLine": 780,
+        "startChar": 12,
+        "endLine": 790,
+        "endChar": 42
+      },
+      "revId": "0c6183b8c19d365f8a299bb94a1c8beb3c74e502",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}