Update patch set 3
Patch Set 3: (3 comments) Hi Tomi. Not sure if I understand correctly but please see my comments below. Patch-set: 3
This commit is contained in:
parent
51e06cad76
commit
aa92e5f457
|
@ -0,0 +1,73 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_24ed13f0",
|
||||
"filename": "fenix/workflow/workflow.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 72,
|
||||
"author": {
|
||||
"id": 27068
|
||||
},
|
||||
"writtenOn": "2018-09-12T01:58:21Z",
|
||||
"side": 1,
|
||||
"message": "IMO, it should also tell the invalid host.",
|
||||
"range": {
|
||||
"startLine": 72,
|
||||
"startChar": 22,
|
||||
"endLine": 72,
|
||||
"endChar": 66
|
||||
},
|
||||
"revId": "11121684b07d267733cb26ca0089a895fe0e31e6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_e49ddb6c",
|
||||
"filename": "fenix/workflow/workflow.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 88,
|
||||
"author": {
|
||||
"id": 27068
|
||||
},
|
||||
"writtenOn": "2018-09-12T01:58:21Z",
|
||||
"side": 1,
|
||||
"message": "Why do you have to empty this after you set the state of the project? What does the state_instances var store?",
|
||||
"range": {
|
||||
"startLine": 88,
|
||||
"startChar": 12,
|
||||
"endLine": 88,
|
||||
"endChar": 40
|
||||
},
|
||||
"revId": "11121684b07d267733cb26ca0089a895fe0e31e6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3f79a3b5_e4b4fbd6",
|
||||
"filename": "fenix/workflow/workflows/default.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 200,
|
||||
"author": {
|
||||
"id": 27068
|
||||
},
|
||||
"writtenOn": "2018-09-12T01:58:21Z",
|
||||
"side": 1,
|
||||
"message": "I\u0027m not sure about the logic of the whole thing but looking at this, whenever you find a project\u0027s state equal to the provided state or the nack or invalid state, we will stop looking. What about the other projects?",
|
||||
"range": {
|
||||
"startLine": 184,
|
||||
"startChar": 0,
|
||||
"endLine": 200,
|
||||
"endChar": 21
|
||||
},
|
||||
"revId": "11121684b07d267733cb26ca0089a895fe0e31e6",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue