Update patch set 4
Patch Set 4: (6 comments) Hi Tomi. Just a couple of comments :) Patch-set: 4 Label: Workflow=0
This commit is contained in:
parent
c1887fdff3
commit
ad0ee4e370
|
@ -95,6 +95,138 @@
|
||||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
"unresolved": false
|
"unresolved": false
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "bfb3d3c7_10a8fad8",
|
||||||
|
"filename": "doc/source/configuration/configuration.rst",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 69,
|
||||||
|
"author": {
|
||||||
|
"id": 27068
|
||||||
|
},
|
||||||
|
"writtenOn": "2019-05-25T02:27:59Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Putting it this way may confuse new contributor. So put some values to the vas like:\n\nos_auth_url \u003d http://127.0.0.1/identity\n...",
|
||||||
|
"range": {
|
||||||
|
"startLine": 58,
|
||||||
|
"startChar": 1,
|
||||||
|
"endLine": 69,
|
||||||
|
"endChar": 30
|
||||||
|
},
|
||||||
|
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "bfb3d3c7_10f6bafa",
|
||||||
|
"filename": "doc/source/configuration/dependensies.rst",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 1,
|
||||||
|
"author": {
|
||||||
|
"id": 27068
|
||||||
|
},
|
||||||
|
"writtenOn": "2019-05-25T02:27:59Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "File name should be dependencies.rst",
|
||||||
|
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "bfb3d3c7_1081da4a",
|
||||||
|
"filename": "doc/source/configuration/dependensies.rst",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 58,
|
||||||
|
"author": {
|
||||||
|
"id": 27068
|
||||||
|
},
|
||||||
|
"writtenOn": "2019-05-25T02:27:59Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Ident these 2 spaces?",
|
||||||
|
"range": {
|
||||||
|
"startLine": 50,
|
||||||
|
"startChar": 0,
|
||||||
|
"endLine": 58,
|
||||||
|
"endChar": 31
|
||||||
|
},
|
||||||
|
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "bfb3d3c7_b099eec4",
|
||||||
|
"filename": "doc/source/configuration/dependensies.rst",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 73,
|
||||||
|
"author": {
|
||||||
|
"id": 27068
|
||||||
|
},
|
||||||
|
"writtenOn": "2019-05-25T02:27:59Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "You should either sudo or run these as root",
|
||||||
|
"range": {
|
||||||
|
"startLine": 72,
|
||||||
|
"startChar": 4,
|
||||||
|
"endLine": 73,
|
||||||
|
"endChar": 65
|
||||||
|
},
|
||||||
|
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "bfb3d3c7_708ff674",
|
||||||
|
"filename": "doc/source/configuration/dependensies.rst",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 80,
|
||||||
|
"author": {
|
||||||
|
"id": 27068
|
||||||
|
},
|
||||||
|
"writtenOn": "2019-05-25T02:27:59Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "https://opendev.org/...",
|
||||||
|
"range": {
|
||||||
|
"startLine": 79,
|
||||||
|
"startChar": 0,
|
||||||
|
"endLine": 80,
|
||||||
|
"endChar": 63
|
||||||
|
},
|
||||||
|
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "bfb3d3c7_f0f0c6ff",
|
||||||
|
"filename": "doc/source/configuration/index.rst",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 19,
|
||||||
|
"author": {
|
||||||
|
"id": 27068
|
||||||
|
},
|
||||||
|
"writtenOn": "2019-05-25T02:27:59Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "dependencies",
|
||||||
|
"range": {
|
||||||
|
"startLine": 19,
|
||||||
|
"startChar": 20,
|
||||||
|
"endLine": 19,
|
||||||
|
"endChar": 32
|
||||||
|
},
|
||||||
|
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
{
|
{
|
||||||
"key": {
|
"key": {
|
||||||
"uuid": "bfb3d3c7_0c323760",
|
"uuid": "bfb3d3c7_0c323760",
|
||||||
|
|
Loading…
Reference in New Issue