Browse Source

Update patch set 4

Patch Set 4:

(6 comments)

Thanks again for all the great comments. I will see how other projects have done for .conf files. I think one should be able to generate those with oslo, so can have default file more complete. I bet there are many options not even listed currently.

Patch-set: 4
changes/41/661241/meta
Gerrit User 15834 2 years ago
committed by Gerrit Code Review
parent
commit
b06d4a12f4
  1. 138
      963aa7981d22a945e14f3981ceafc207e8f233d3

138
963aa7981d22a945e14f3981ceafc207e8f233d3

@ -118,6 +118,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_919069ef",
"filename": "doc/source/configuration/configuration.rst",
"patchSetId": 4
},
"lineNbr": 69,
"author": {
"id": 15834
},
"writtenOn": "2019-05-27T04:57:49Z",
"side": 1,
"message": "Yes, thanks",
"parentUuid": "bfb3d3c7_10a8fad8",
"range": {
"startLine": 58,
"startChar": 1,
"endLine": 69,
"endChar": 30
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_10f6bafa",
@ -135,6 +159,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_b18d6dd4",
"filename": "doc/source/configuration/dependensies.rst",
"patchSetId": 4
},
"lineNbr": 1,
"author": {
"id": 15834
},
"writtenOn": "2019-05-27T04:57:49Z",
"side": 1,
"message": "Nice catch :)",
"parentUuid": "bfb3d3c7_10f6bafa",
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_1081da4a",
@ -158,6 +200,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_31bbbd72",
"filename": "doc/source/configuration/dependensies.rst",
"patchSetId": 4
},
"lineNbr": 58,
"author": {
"id": 15834
},
"writtenOn": "2019-05-27T04:57:49Z",
"side": 1,
"message": "I will check this, thanks",
"parentUuid": "bfb3d3c7_1081da4a",
"range": {
"startLine": 50,
"startChar": 0,
"endLine": 58,
"endChar": 31
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_b099eec4",
@ -181,6 +247,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_116b19f1",
"filename": "doc/source/configuration/dependensies.rst",
"patchSetId": 4
},
"lineNbr": 73,
"author": {
"id": 15834
},
"writtenOn": "2019-05-27T04:57:49Z",
"side": 1,
"message": "Have to check this in all files. Maybe adding sudo should indicate \"the both\".",
"parentUuid": "bfb3d3c7_b099eec4",
"range": {
"startLine": 72,
"startChar": 4,
"endLine": 73,
"endChar": 65
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_708ff674",
@ -204,6 +294,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_514e7197",
"filename": "doc/source/configuration/dependensies.rst",
"patchSetId": 4
},
"lineNbr": 80,
"author": {
"id": 15834
},
"writtenOn": "2019-05-27T04:57:49Z",
"side": 1,
"message": "yes, copy/paste from old config, thanks.",
"parentUuid": "bfb3d3c7_708ff674",
"range": {
"startLine": 79,
"startChar": 0,
"endLine": 80,
"endChar": 63
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_f0f0c6ff",
@ -227,6 +341,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_71537540",
"filename": "doc/source/configuration/index.rst",
"patchSetId": 4
},
"lineNbr": 19,
"author": {
"id": 15834
},
"writtenOn": "2019-05-27T04:57:49Z",
"side": 1,
"message": "Thanks",
"parentUuid": "bfb3d3c7_f0f0c6ff",
"range": {
"startLine": 19,
"startChar": 20,
"endLine": 19,
"endChar": 32
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_0c323760",

Loading…
Cancel
Save