Update patch set 2

Patch Set 2: (6 comments) Hi Tomi, Just a couple of comments. Thanks. Patch-set: 2 Label: Workflow=0
2019-05-08 05:22:47 +00:00 · 2019-05-08 05:22:47 +00:00 · ce322b29bc
parent 334cfc90cb
commit ce322b29bc
1 changed files with 142 additions and 0 deletions
--- a/142
+++ b/142
@ -0,0 +1,142 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "dfbec78f_5f37a6e4",
+        "filename": "fenix/workflow/workflows/default.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 613,
+      "author": {
+        "id": 27068
+      },
+      "writtenOn": "2019-05-08T05:22:47Z",
+      "side": 1,
+      "message": "So \"retries\" is for the whole process and \"migrate_retry\" for migration? Btw, it should be migrate_retries IMO.",
+      "range": {
+        "startLine": 612,
+        "startChar": 0,
+        "endLine": 613,
+        "endChar": 29
+      },
+      "revId": "b6882f43d9dec27624a21afb4049cab4d2aafd6e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "dfbec78f_9f0c3e3c",
+        "filename": "fenix/workflow/workflows/default.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 614,
+      "author": {
+        "id": 27068
+      },
+      "writtenOn": "2019-05-08T05:22:47Z",
+      "side": 1,
+      "message": "just random?",
+      "range": {
+        "startLine": 614,
+        "startChar": 29,
+        "endLine": 614,
+        "endChar": 32
+      },
+      "revId": "b6882f43d9dec27624a21afb4049cab4d2aafd6e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "dfbec78f_df2b967f",
+        "filename": "fenix/workflow/workflows/default.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 615,
+      "author": {
+        "id": 27068
+      },
+      "writtenOn": "2019-05-08T05:22:47Z",
+      "side": 1,
+      "message": "I get what you\u0027re doing here. Could you please add some note here before we can have a more stable solution.",
+      "range": {
+        "startLine": 615,
+        "startChar": 16,
+        "endLine": 615,
+        "endChar": 29
+      },
+      "revId": "b6882f43d9dec27624a21afb4049cab4d2aafd6e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "dfbec78f_ff353adb",
+        "filename": "fenix/workflow/workflows/default.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 643,
+      "author": {
+        "id": 27068
+      },
+      "writtenOn": "2019-05-08T05:22:47Z",
+      "side": 1,
+      "message": "I\u0027m not sure how it is like this.",
+      "range": {
+        "startLine": 643,
+        "startChar": 20,
+        "endLine": 643,
+        "endChar": 55
+      },
+      "revId": "b6882f43d9dec27624a21afb4049cab4d2aafd6e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "dfbec78f_1f312eed",
+        "filename": "fenix/workflow/workflows/default.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 647,
+      "author": {
+        "id": 27068
+      },
+      "writtenOn": "2019-05-08T05:22:47Z",
+      "side": 1,
+      "message": "?",
+      "range": {
+        "startLine": 647,
+        "startChar": 20,
+        "endLine": 647,
+        "endChar": 31
+      },
+      "revId": "b6882f43d9dec27624a21afb4049cab4d2aafd6e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "dfbec78f_df795693",
+        "filename": "fenix/workflow/workflows/default.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 661,
+      "author": {
+        "id": 27068
+      },
+      "writtenOn": "2019-05-08T05:22:47Z",
+      "side": 1,
+      "message": "It will return False if it does not finish within the while loop so we can just return False outside all of these line:\n\n    LOG.error...\nexcept Exception as e:\n    Log.error...\n\nreturn False",
+      "range": {
+        "startLine": 657,
+        "startChar": 0,
+        "endLine": 661,
+        "endChar": 24
+      },
+      "revId": "b6882f43d9dec27624a21afb4049cab4d2aafd6e",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}