x
/
fenix
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(6 comments)

Hi Tomi. Just some comments. Thanks.

Patch-set: 4
Label: Verified=0
This commit is contained in:
Gerrit User 27068 2018-11-10 01:00:54 +00:00 committed by Gerrit Code Review
parent fb302eb4b2
commit d9f0d8f07d
1 changed files with 115 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

115
91c2df8f0b6d6f7e2f4e77e887c38d1c79847728
View File

@ -1,5 +1,28 @@
{
"comments": [
{
"key": {
"uuid": "3f79a3b5_4a6f4392",
"filename": "doc/source/api/admin.rst",
"patchSetId": 4
},
"lineNbr": 26,
"author": {
"id": 27068
},
"writtenOn": "2018-11-10T01:00:54Z",
"side": 1,
"message": "Put them into an unordered list maybe?",
"range": {
"startLine": 22,
"startChar": 0,
"endLine": 26,
"endChar": 46
},
"revId": "91c2df8f0b6d6f7e2f4e77e887c38d1c79847728",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_08864217",
@ -22,6 +45,98 @@
"revId": "91c2df8f0b6d6f7e2f4e77e887c38d1c79847728",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_2a60c79d",
"filename": "doc/source/api/admin.rst",
"patchSetId": 4
},
"lineNbr": 54,
"author": {
"id": 27068
},
"writtenOn": "2018-11-10T01:00:54Z",
"side": 1,
"message": "@Gergely: +1",
"parentUuid": "3f79a3b5_08864217",
"range": {
"startLine": 54,
"startChar": 21,
"endLine": 54,
"endChar": 35
},
"revId": "91c2df8f0b6d6f7e2f4e77e887c38d1c79847728",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_ca3273c0",
"filename": "doc/source/api/admin.rst",
"patchSetId": 4
},
"lineNbr": 110,
"author": {
"id": 27068
},
"writtenOn": "2018-11-10T01:00:54Z",
"side": 1,
"message": "/",
"revId": "91c2df8f0b6d6f7e2f4e77e887c38d1c79847728",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_ea35efa7",
"filename": "doc/source/api/admin.rst",
"patchSetId": 4
},
"lineNbr": 118,
"author": {
"id": 27068
},
"writtenOn": "2018-11-10T01:00:54Z",
"side": 1,
"message": "/",
"revId": "91c2df8f0b6d6f7e2f4e77e887c38d1c79847728",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_8a38fb9d",
"filename": "doc/source/api/admin.rst",
"patchSetId": 4
},
"lineNbr": 144,
"author": {
"id": 27068
},
"writtenOn": "2018-11-10T01:00:54Z",
"side": 1,
"message": "/",
"revId": "91c2df8f0b6d6f7e2f4e77e887c38d1c79847728",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_aa3b7797",
"filename": "doc/source/api/admin.rst",
"patchSetId": 4
},
"lineNbr": 170,
"author": {
"id": 27068
},
"writtenOn": "2018-11-10T01:00:54Z",
"side": 1,
"message": "/",
"revId": "91c2df8f0b6d6f7e2f4e77e887c38d1c79847728",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}