From f1f7f0d03aea7e49fb9ba44fbde1041d3af54e43 Mon Sep 17 00:00:00 2001 From: Gerrit User 15834 <15834@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Wed, 22 Apr 2020 06:52:00 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: (7 comments) Thanks, this was very good. It made me realize there all and all need to be more explained. Patch-set: 2 --- 0607b6520e9883c74384969510626aa9913d3bb9 | 168 +++++++++++++++++++++++ 1 file changed, 168 insertions(+) diff --git a/0607b6520e9883c74384969510626aa9913d3bb9 b/0607b6520e9883c74384969510626aa9913d3bb9 index 7520727..07f0d34 100644 --- a/0607b6520e9883c74384969510626aa9913d3bb9 +++ b/0607b6520e9883c74384969510626aa9913d3bb9 @@ -23,6 +23,30 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "1f493fa4_53704873", + "filename": "doc/source/admin/index.rst", + "patchSetId": 2 + }, + "lineNbr": 8, + "author": { + "id": 15834 + }, + "writtenOn": "2020-04-22T06:52:00Z", + "side": 1, + "message": "Agree, this should tell about Fenix, \u0027itself\u0027 was somehow to reflect other components (VNFM, VNFs and admin UI). Then again there is no indication where they should reside and as they are really also out of Fenix scope.", + "parentUuid": "1f493fa4_ae821ac7", + "range": { + "startLine": 8, + "startChar": 6, + "endLine": 8, + "endChar": 12 + }, + "revId": "0607b6520e9883c74384969510626aa9913d3bb9", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "1f493fa4_ae5b3a85", @@ -46,6 +70,30 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "1f493fa4_936ad07d", + "filename": "doc/source/admin/index.rst", + "patchSetId": 2 + }, + "lineNbr": 9, + "author": { + "id": 15834 + }, + "writtenOn": "2020-04-22T06:52:00Z", + "side": 1, + "message": "Ok, this was more Finnish language style. Thanks.", + "parentUuid": "1f493fa4_ae5b3a85", + "range": { + "startLine": 8, + "startChar": 54, + "endLine": 9, + "endChar": 12 + }, + "revId": "0607b6520e9883c74384969510626aa9913d3bb9", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "1f493fa4_9bf4cbd1", @@ -104,6 +152,30 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "1f493fa4_f32d1447", + "filename": "doc/source/admin/index.rst", + "patchSetId": 2 + }, + "lineNbr": 20, + "author": { + "id": 15834 + }, + "writtenOn": "2020-04-22T06:52:00Z", + "side": 1, + "message": "Done", + "parentUuid": "1f493fa4_8e18fe81", + "range": { + "startLine": 19, + "startChar": 44, + "endLine": 20, + "endChar": 77 + }, + "revId": "0607b6520e9883c74384969510626aa9913d3bb9", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "1f493fa4_7cc60319", @@ -127,6 +199,30 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "1f493fa4_f32a34e5", + "filename": "doc/source/admin/index.rst", + "patchSetId": 2 + }, + "lineNbr": 32, + "author": { + "id": 15834 + }, + "writtenOn": "2020-04-22T06:52:00Z", + "side": 1, + "message": "If something went wrong and Fenix was not able to continue, it will enter to state MAINTENANCE_FAILED. It saves prev_state. prev_state can then be used when the issue is fixed and the admin wants to continue the maintenance session. This is explained with the new API interface: GET /v1/maintenance/{session_id}/detail. I make a link to it.", + "parentUuid": "1f493fa4_7cc60319", + "range": { + "startLine": 32, + "startChar": 52, + "endLine": 32, + "endChar": 56 + }, + "revId": "0607b6520e9883c74384969510626aa9913d3bb9", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "1f493fa4_dbfe53ad", @@ -208,6 +304,30 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "1f493fa4_330e5c8d", + "filename": "doc/source/admin/index.rst", + "patchSetId": 2 + }, + "lineNbr": 42, + "author": { + "id": 15834 + }, + "writtenOn": "2020-04-22T06:52:00Z", + "side": 1, + "message": "I rework the whole sentence", + "parentUuid": "1f493fa4_4780948c", + "range": { + "startLine": 41, + "startChar": 0, + "endLine": 42, + "endChar": 68 + }, + "revId": "0607b6520e9883c74384969510626aa9913d3bb9", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "1f493fa4_277d88b1", @@ -231,6 +351,30 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "1f493fa4_53696823", + "filename": "doc/source/admin/index.rst", + "patchSetId": 2 + }, + "lineNbr": 43, + "author": { + "id": 15834 + }, + "writtenOn": "2020-04-22T06:52:00Z", + "side": 1, + "message": "Done", + "parentUuid": "1f493fa4_277d88b1", + "range": { + "startLine": 43, + "startChar": 65, + "endLine": 43, + "endChar": 73 + }, + "revId": "0607b6520e9883c74384969510626aa9913d3bb9", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "1f493fa4_82fe0a03", @@ -254,6 +398,30 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "1f493fa4_f361943b", + "filename": "doc/source/admin/index.rst", + "patchSetId": 2 + }, + "lineNbr": 44, + "author": { + "id": 15834 + }, + "writtenOn": "2020-04-22T06:52:00Z", + "side": 1, + "message": "I rework the whole chapter", + "parentUuid": "1f493fa4_82fe0a03", + "range": { + "startLine": 44, + "startChar": 7, + "endLine": 44, + "endChar": 56 + }, + "revId": "0607b6520e9883c74384969510626aa9913d3bb9", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "1f493fa4_5a2a34e7",