fenix/963aa7981d22a945e14f3981cea...

134 lines
3.9 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "bfb3d3c7_2c461bc2",
"filename": "doc/source/configuration/configuration.rst",
"patchSetId": 4
},
"lineNbr": 49,
"author": {
"id": 29908
},
"writtenOn": "2019-05-24T10:21:00Z",
"side": 1,
"message": "How about adding this part with default value in devstack/plugin.sh?",
"range": {
"startLine": 38,
"startChar": 7,
"endLine": 49,
"endChar": 38
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_8cb0678c",
"filename": "doc/source/configuration/configuration.rst",
"patchSetId": 4
},
"lineNbr": 49,
"author": {
"id": 15834
},
"writtenOn": "2019-05-24T10:37:15Z",
"side": 1,
"message": "This is optional if want to change. Default values are given in code that are exactly these values.",
"parentUuid": "bfb3d3c7_2c461bc2",
"range": {
"startLine": 38,
"startChar": 7,
"endLine": 49,
"endChar": 38
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_a7b3040a",
"filename": "doc/source/configuration/configuration.rst",
"patchSetId": 4
},
"lineNbr": 49,
"author": {
"id": 29908
},
"writtenOn": "2019-05-24T12:05:34Z",
"side": 1,
"message": "Yes. But IMO, users should be possible to use the conf file for changing most of the configurations without finding related codes or documents.\n\nIn my case, I usually see the conf file to recognize configurable ranges before searching.",
"parentUuid": "bfb3d3c7_8cb0678c",
"range": {
"startLine": 38,
"startChar": 7,
"endLine": 49,
"endChar": 38
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_b8f0fefe",
"filename": "doc/source/configuration/configuration.rst",
"patchSetId": 4
},
"lineNbr": 49,
"author": {
"id": 15834
},
"writtenOn": "2019-05-24T16:03:22Z",
"side": 1,
"message": "+1 Yes, you are right, now I got the point. Everything that you do not need to change normally should exist in conf file while commented out with saying also the default value used.",
"parentUuid": "bfb3d3c7_a7b3040a",
"range": {
"startLine": 38,
"startChar": 7,
"endLine": 49,
"endChar": 38
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_0c323760",
"filename": "doc/source/install/install-ubuntu.rst",
"patchSetId": 4
},
"lineNbr": 21,
"author": {
"id": 29908
},
"writtenOn": "2019-05-24T10:21:00Z",
"side": 1,
"message": "fenix-engine",
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_4ca6ef55",
"filename": "doc/source/install/install-ubuntu.rst",
"patchSetId": 4
},
"lineNbr": 21,
"author": {
"id": 15834
},
"writtenOn": "2019-05-24T10:37:15Z",
"side": 1,
"message": "Thanks, need to fix this",
"parentUuid": "bfb3d3c7_0c323760",
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}