x
/
fenix
Code Issues Proposed changes
fenix/963aa7981d22a945e14f3981cea...

428 lines
12 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "bfb3d3c7_2c461bc2",
"filename": "doc/source/configuration/configuration.rst",
"patchSetId": 4
},
"lineNbr": 49,
"author": {
"id": 29908
},
"writtenOn": "2019-05-24T10:21:00Z",
"side": 1,
"message": "How about adding this part with default value in devstack/plugin.sh?",
"range": {
"startLine": 38,
"startChar": 7,
"endLine": 49,
"endChar": 38
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_8cb0678c",
"filename": "doc/source/configuration/configuration.rst",
"patchSetId": 4
},
"lineNbr": 49,
"author": {
"id": 15834
},
"writtenOn": "2019-05-24T10:37:15Z",
"side": 1,
"message": "This is optional if want to change. Default values are given in code that are exactly these values.",
"parentUuid": "bfb3d3c7_2c461bc2",
"range": {
"startLine": 38,
"startChar": 7,
"endLine": 49,
"endChar": 38
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_a7b3040a",
"filename": "doc/source/configuration/configuration.rst",
"patchSetId": 4
},
"lineNbr": 49,
"author": {
"id": 29908
},
"writtenOn": "2019-05-24T12:05:34Z",
"side": 1,
"message": "Yes. But IMO, users should be possible to use the conf file for changing most of the configurations without finding related codes or documents.\n\nIn my case, I usually see the conf file to recognize configurable ranges before searching.",
"parentUuid": "bfb3d3c7_8cb0678c",
"range": {
"startLine": 38,
"startChar": 7,
"endLine": 49,
"endChar": 38
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_b8f0fefe",
"filename": "doc/source/configuration/configuration.rst",
"patchSetId": 4
},
"lineNbr": 49,
"author": {
"id": 15834
},
"writtenOn": "2019-05-24T16:03:22Z",
"side": 1,
"message": "+1 Yes, you are right, now I got the point. Everything that you do not need to change normally should exist in conf file while commented out with saying also the default value used.",
"parentUuid": "bfb3d3c7_a7b3040a",
"range": {
"startLine": 38,
"startChar": 7,
"endLine": 49,
"endChar": 38
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_d40faf34",
"filename": "doc/source/configuration/configuration.rst",
"patchSetId": 4
},
"lineNbr": 49,
"author": {
"id": 15834
},
"writtenOn": "2019-05-27T06:41:17Z",
"side": 1,
"message": "Ok, so we need separate change for addressing the sample config generation. Ultimately, it should be used to generate this documentation. Also, DevStack needs separate change that might add the most commonly needed variables like those mentioned here. Meanwhile, I would complete this patch set as is to have something documented for configuration.",
"parentUuid": "bfb3d3c7_b8f0fefe",
"range": {
"startLine": 38,
"startChar": 7,
"endLine": 49,
"endChar": 38
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_10a8fad8",
"filename": "doc/source/configuration/configuration.rst",
"patchSetId": 4
},
"lineNbr": 69,
"author": {
"id": 27068
},
"writtenOn": "2019-05-25T02:27:59Z",
"side": 1,
"message": "Putting it this way may confuse new contributor. So put some values to the vas like:\n\nos_auth_url \u003d http://127.0.0.1/identity\n...",
"range": {
"startLine": 58,
"startChar": 1,
"endLine": 69,
"endChar": 30
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_919069ef",
"filename": "doc/source/configuration/configuration.rst",
"patchSetId": 4
},
"lineNbr": 69,
"author": {
"id": 15834
},
"writtenOn": "2019-05-27T04:57:49Z",
"side": 1,
"message": "Yes, thanks",
"parentUuid": "bfb3d3c7_10a8fad8",
"range": {
"startLine": 58,
"startChar": 1,
"endLine": 69,
"endChar": 30
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_10f6bafa",
"filename": "doc/source/configuration/dependensies.rst",
"patchSetId": 4
},
"lineNbr": 1,
"author": {
"id": 27068
},
"writtenOn": "2019-05-25T02:27:59Z",
"side": 1,
"message": "File name should be dependencies.rst",
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_b18d6dd4",
"filename": "doc/source/configuration/dependensies.rst",
"patchSetId": 4
},
"lineNbr": 1,
"author": {
"id": 15834
},
"writtenOn": "2019-05-27T04:57:49Z",
"side": 1,
"message": "Nice catch :)",
"parentUuid": "bfb3d3c7_10f6bafa",
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_1081da4a",
"filename": "doc/source/configuration/dependensies.rst",
"patchSetId": 4
},
"lineNbr": 58,
"author": {
"id": 27068
},
"writtenOn": "2019-05-25T02:27:59Z",
"side": 1,
"message": "Ident these 2 spaces?",
"range": {
"startLine": 50,
"startChar": 0,
"endLine": 58,
"endChar": 31
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_31bbbd72",
"filename": "doc/source/configuration/dependensies.rst",
"patchSetId": 4
},
"lineNbr": 58,
"author": {
"id": 15834
},
"writtenOn": "2019-05-27T04:57:49Z",
"side": 1,
"message": "I will check this, thanks",
"parentUuid": "bfb3d3c7_1081da4a",
"range": {
"startLine": 50,
"startChar": 0,
"endLine": 58,
"endChar": 31
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_b099eec4",
"filename": "doc/source/configuration/dependensies.rst",
"patchSetId": 4
},
"lineNbr": 73,
"author": {
"id": 27068
},
"writtenOn": "2019-05-25T02:27:59Z",
"side": 1,
"message": "You should either sudo or run these as root",
"range": {
"startLine": 72,
"startChar": 4,
"endLine": 73,
"endChar": 65
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_116b19f1",
"filename": "doc/source/configuration/dependensies.rst",
"patchSetId": 4
},
"lineNbr": 73,
"author": {
"id": 15834
},
"writtenOn": "2019-05-27T04:57:49Z",
"side": 1,
"message": "Have to check this in all files. Maybe adding sudo should indicate \"the both\".",
"parentUuid": "bfb3d3c7_b099eec4",
"range": {
"startLine": 72,
"startChar": 4,
"endLine": 73,
"endChar": 65
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_708ff674",
"filename": "doc/source/configuration/dependensies.rst",
"patchSetId": 4
},
"lineNbr": 80,
"author": {
"id": 27068
},
"writtenOn": "2019-05-25T02:27:59Z",
"side": 1,
"message": "https://opendev.org/...",
"range": {
"startLine": 79,
"startChar": 0,
"endLine": 80,
"endChar": 63
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_514e7197",
"filename": "doc/source/configuration/dependensies.rst",
"patchSetId": 4
},
"lineNbr": 80,
"author": {
"id": 15834
},
"writtenOn": "2019-05-27T04:57:49Z",
"side": 1,
"message": "yes, copy/paste from old config, thanks.",
"parentUuid": "bfb3d3c7_708ff674",
"range": {
"startLine": 79,
"startChar": 0,
"endLine": 80,
"endChar": 63
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_f0f0c6ff",
"filename": "doc/source/configuration/index.rst",
"patchSetId": 4
},
"lineNbr": 19,
"author": {
"id": 27068
},
"writtenOn": "2019-05-25T02:27:59Z",
"side": 1,
"message": "dependencies",
"range": {
"startLine": 19,
"startChar": 20,
"endLine": 19,
"endChar": 32
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_71537540",
"filename": "doc/source/configuration/index.rst",
"patchSetId": 4
},
"lineNbr": 19,
"author": {
"id": 15834
},
"writtenOn": "2019-05-27T04:57:49Z",
"side": 1,
"message": "Thanks",
"parentUuid": "bfb3d3c7_f0f0c6ff",
"range": {
"startLine": 19,
"startChar": 20,
"endLine": 19,
"endChar": 32
},
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_0c323760",
"filename": "doc/source/install/install-ubuntu.rst",
"patchSetId": 4
},
"lineNbr": 21,
"author": {
"id": 29908
},
"writtenOn": "2019-05-24T10:21:00Z",
"side": 1,
"message": "fenix-engine",
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "bfb3d3c7_4ca6ef55",
"filename": "doc/source/install/install-ubuntu.rst",
"patchSetId": 4
},
"lineNbr": 21,
"author": {
"id": 15834
},
"writtenOn": "2019-05-24T10:37:15Z",
"side": 1,
"message": "Thanks, need to fix this",
"parentUuid": "bfb3d3c7_0c323760",
"revId": "963aa7981d22a945e14f3981ceafc207e8f233d3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink