fenix/cff7fe568eed41882350514e5ad40e328457b254
Gerrit User 15834 71e19450fd Update patch set 3
Patch Set 3:

(14 comments)

Thank you for the great and valuable input :)

Patch-set: 3
Label: Verified=0
2018-11-08 10:14:01 +00:00

668 lines
18 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "3f79a3b5_d04a4b23",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 13,
"author": {
"id": 27068
},
"writtenOn": "2018-11-08T08:26:49Z",
"side": 1,
"message": ".. rest_method:: POST /v1/maintenance",
"range": {
"startLine": 13,
"startChar": 0,
"endLine": 13,
"endChar": 21
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_6bccac32",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 13,
"author": {
"id": 15834
},
"writtenOn": "2018-11-08T10:14:01Z",
"side": 1,
"message": "Thanks, maybe postpone as suggested by Gergo",
"parentUuid": "3f79a3b5_d04a4b23",
"range": {
"startLine": 13,
"startChar": 0,
"endLine": 13,
"endChar": 21
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_90b293e7",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 38,
"author": {
"id": 21723
},
"writtenOn": "2018-11-08T08:50:07Z",
"side": 1,
"message": "start",
"range": {
"startLine": 38,
"startChar": 58,
"endLine": 38,
"endChar": 63
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_cbdaa0e5",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 38,
"author": {
"id": 15834
},
"writtenOn": "2018-11-08T10:14:01Z",
"side": 1,
"message": "Done",
"parentUuid": "3f79a3b5_90b293e7",
"range": {
"startLine": 38,
"startChar": 58,
"endLine": 38,
"endChar": 63
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_d02b2b7a",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 45,
"author": {
"id": 27068
},
"writtenOn": "2018-11-08T08:26:49Z",
"side": 1,
"message": "You can just put them on the same table with the above. Add another column name \"Implemented\" and then for each attribute that is not implemented, says \"NO\" or something.",
"range": {
"startLine": 45,
"startChar": 0,
"endLine": 45,
"endChar": 40
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_6b682cf2",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 45,
"author": {
"id": 15834
},
"writtenOn": "2018-11-08T10:14:01Z",
"side": 1,
"message": "Done",
"parentUuid": "3f79a3b5_d02b2b7a",
"range": {
"startLine": 45,
"startChar": 0,
"endLine": 45,
"endChar": 40
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_900e138d",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 48,
"author": {
"id": 21723
},
"writtenOn": "2018-11-08T08:50:07Z",
"side": 1,
"message": "You should indicate if a parameter is mandatory or optional.",
"range": {
"startLine": 48,
"startChar": 2,
"endLine": 48,
"endChar": 6
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_a6751999",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 48,
"author": {
"id": 15834
},
"writtenOn": "2018-11-08T10:14:01Z",
"side": 1,
"message": "Done",
"parentUuid": "3f79a3b5_900e138d",
"range": {
"startLine": 48,
"startChar": 2,
"endLine": 48,
"endChar": 6
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_d0e9ebab",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 52,
"author": {
"id": 21723
},
"writtenOn": "2018-11-08T08:50:07Z",
"side": 1,
"message": "Isn\u0027t there a way to indicate that this is part of download, like download.url or something?",
"range": {
"startLine": 52,
"startChar": 2,
"endLine": 52,
"endChar": 5
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_466685f2",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 52,
"author": {
"id": 15834
},
"writtenOn": "2018-11-08T10:14:01Z",
"side": 1,
"message": "Done",
"parentUuid": "3f79a3b5_d0e9ebab",
"range": {
"startLine": 52,
"startChar": 2,
"endLine": 52,
"endChar": 5
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_502b9be7",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 56,
"author": {
"id": 21723
},
"writtenOn": "2018-11-08T08:50:07Z",
"side": 1,
"message": "List of actions is missing from here.\nThis is not in the example.",
"range": {
"startLine": 56,
"startChar": 2,
"endLine": 56,
"endChar": 6
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_46ac45a7",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 56,
"author": {
"id": 15834
},
"writtenOn": "2018-11-08T10:14:01Z",
"side": 1,
"message": "Done",
"parentUuid": "3f79a3b5_502b9be7",
"range": {
"startLine": 56,
"startChar": 2,
"endLine": 56,
"endChar": 6
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_9047f352",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 110,
"author": {
"id": 27068
},
"writtenOn": "2018-11-08T08:26:49Z",
"side": 1,
"message": ".. rest_method:: PUT /v1/maintenance/\u003csession_id\u003e",
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_5052bb6b",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 110,
"author": {
"id": 21723
},
"writtenOn": "2018-11-08T08:50:07Z",
"side": 1,
"message": "rest_method works only is the API ref is built with the os_api_ref extension as it is described in [1].\n\nI would propose to get this merged using this handcrafted method and in parrallel I will start working on a change where I use the os_api_ref.\n\n[1]: https://docs.openstack.org/doc-contrib-guide/api-guides.html",
"parentUuid": "3f79a3b5_9047f352",
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_e691d151",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 110,
"author": {
"id": 15834
},
"writtenOn": "2018-11-08T10:14:01Z",
"side": 1,
"message": "Yes, it might be good to have these done later",
"parentUuid": "3f79a3b5_5052bb6b",
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_d087ab5b",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 118,
"author": {
"id": 27068
},
"writtenOn": "2018-11-08T08:26:49Z",
"side": 1,
"message": ".. rest_method:: GET /v1/maintenance",
"range": {
"startLine": 118,
"startChar": 0,
"endLine": 118,
"endChar": 19
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_66e2a1d5",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 118,
"author": {
"id": 15834
},
"writtenOn": "2018-11-08T10:14:01Z",
"side": 1,
"message": "thanks, we could postpone this change",
"parentUuid": "3f79a3b5_d087ab5b",
"range": {
"startLine": 118,
"startChar": 0,
"endLine": 118,
"endChar": 19
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_f0842759",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 144,
"author": {
"id": 27068
},
"writtenOn": "2018-11-08T08:26:49Z",
"side": 1,
"message": ".. rest_method:: GET /v1/maintenance/\u003csession_id\u003e",
"range": {
"startLine": 144,
"startChar": 0,
"endLine": 144,
"endChar": 32
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_a605197b",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 144,
"author": {
"id": 15834
},
"writtenOn": "2018-11-08T10:14:01Z",
"side": 1,
"message": "thanks, we could postpone this change",
"parentUuid": "3f79a3b5_f0842759",
"range": {
"startLine": 144,
"startChar": 0,
"endLine": 144,
"endChar": 32
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_30d4df4a",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 170,
"author": {
"id": 27068
},
"writtenOn": "2018-11-08T08:26:49Z",
"side": 1,
"message": ".. rest_method:: DELETE /v1/maintenance/\u003csession_id\u003e",
"range": {
"startLine": 170,
"startChar": 0,
"endLine": 170,
"endChar": 35
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_c6e935ac",
"filename": "doc/source/api/admin.rst",
"patchSetId": 3
},
"lineNbr": 170,
"author": {
"id": 15834
},
"writtenOn": "2018-11-08T10:14:01Z",
"side": 1,
"message": "thanks, we could postpone this change",
"parentUuid": "3f79a3b5_30d4df4a",
"range": {
"startLine": 170,
"startChar": 0,
"endLine": 170,
"endChar": 35
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_50507bd1",
"filename": "doc/source/api/project.rst",
"patchSetId": 3
},
"lineNbr": 25,
"author": {
"id": 27068
},
"writtenOn": "2018-11-08T08:26:49Z",
"side": 1,
"message": ".. rest_method:: GET /v1/maintenance/\u003csession_id\u003e/\u003cprojet_id\u003e/",
"range": {
"startLine": 25,
"startChar": 0,
"endLine": 25,
"endChar": 45
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_462be5e7",
"filename": "doc/source/api/project.rst",
"patchSetId": 3
},
"lineNbr": 25,
"author": {
"id": 15834
},
"writtenOn": "2018-11-08T10:14:01Z",
"side": 1,
"message": "thanks, we could postpone this change",
"parentUuid": "3f79a3b5_50507bd1",
"range": {
"startLine": 25,
"startChar": 0,
"endLine": 25,
"endChar": 45
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_f060a7a0",
"filename": "doc/source/api/project.rst",
"patchSetId": 3
},
"lineNbr": 59,
"author": {
"id": 27068
},
"writtenOn": "2018-11-08T08:26:49Z",
"side": 1,
"message": ".. rest_method:: PUT /v1/maintenance/\u003csession_id\u003e/\u003cprojet_id\u003e/",
"range": {
"startLine": 59,
"startChar": 0,
"endLine": 59,
"endChar": 45
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_c63e1526",
"filename": "doc/source/api/project.rst",
"patchSetId": 3
},
"lineNbr": 59,
"author": {
"id": 15834
},
"writtenOn": "2018-11-08T10:14:01Z",
"side": 1,
"message": "thanks, we could postpone this change",
"parentUuid": "3f79a3b5_f060a7a0",
"range": {
"startLine": 59,
"startChar": 0,
"endLine": 59,
"endChar": 45
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_10fe8338",
"filename": "doc/source/api/project.rst",
"patchSetId": 3
},
"lineNbr": 69,
"author": {
"id": 21723
},
"writtenOn": "2018-11-08T08:50:07Z",
"side": 1,
"message": "What are the possible reply states?",
"range": {
"startLine": 69,
"startChar": 34,
"endLine": 69,
"endChar": 45
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_e614719b",
"filename": "doc/source/api/project.rst",
"patchSetId": 3
},
"lineNbr": 69,
"author": {
"id": 15834
},
"writtenOn": "2018-11-08T10:14:01Z",
"side": 1,
"message": "ok, filling more in this table and not after",
"parentUuid": "3f79a3b5_10fe8338",
"range": {
"startLine": 69,
"startChar": 34,
"endLine": 69,
"endChar": 45
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_d0f32b6d",
"filename": "doc/source/api/project.rst",
"patchSetId": 3
},
"lineNbr": 85,
"author": {
"id": 21723
},
"writtenOn": "2018-11-08T08:50:07Z",
"side": 1,
"message": "I think it is better to have this in the Description of the table.",
"range": {
"startLine": 82,
"startChar": 0,
"endLine": 85,
"endChar": 60
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_4604456c",
"filename": "doc/source/api/project.rst",
"patchSetId": 3
},
"lineNbr": 85,
"author": {
"id": 15834
},
"writtenOn": "2018-11-08T10:14:01Z",
"side": 1,
"message": "Done",
"parentUuid": "3f79a3b5_d0f32b6d",
"range": {
"startLine": 82,
"startChar": 0,
"endLine": 85,
"endChar": 60
},
"revId": "cff7fe568eed41882350514e5ad40e328457b254",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}