273 lines
7.7 KiB
Plaintext
273 lines
7.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "9f6a8fd7_3fe99919",
|
|
"filename": "fixtures_git/__init__.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 30,
|
|
"author": {
|
|
"id": 1054
|
|
},
|
|
"writtenOn": "2018-04-17T15:10:05Z",
|
|
"side": 1,
|
|
"message": "stick this in a utils.py file?",
|
|
"range": {
|
|
"startLine": 30,
|
|
"startChar": 0,
|
|
"endLine": 30,
|
|
"endChar": 28
|
|
},
|
|
"revId": "c1ab539188b6f80723cff4581cabeb6970661f07",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9f6a8fd7_624e95c2",
|
|
"filename": "fixtures_git/__init__.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 30,
|
|
"author": {
|
|
"id": 1390
|
|
},
|
|
"writtenOn": "2018-04-30T11:50:39Z",
|
|
"side": 1,
|
|
"message": "Possibly not needed if its not intended to be consumed by end users (see comment below also)",
|
|
"parentUuid": "9f6a8fd7_3fe99919",
|
|
"range": {
|
|
"startLine": 30,
|
|
"startChar": 0,
|
|
"endLine": 30,
|
|
"endChar": 28
|
|
},
|
|
"revId": "c1ab539188b6f80723cff4581cabeb6970661f07",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9f6a8fd7_1faa95d3",
|
|
"filename": "fixtures_git/__init__.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 47,
|
|
"author": {
|
|
"id": 1054
|
|
},
|
|
"writtenOn": "2018-04-17T15:10:05Z",
|
|
"side": 1,
|
|
"message": "My thinking is maybe to move this to a utils module in this project and merge just that with the tests first, or maybe add a \u0027sort.py\u0027 file to encapsulate this algorithm.",
|
|
"revId": "c1ab539188b6f80723cff4581cabeb6970661f07",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9f6a8fd7_22617d3a",
|
|
"filename": "fixtures_git/__init__.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 47,
|
|
"author": {
|
|
"id": 1390
|
|
},
|
|
"writtenOn": "2018-04-30T11:50:39Z",
|
|
"side": 1,
|
|
"message": "Should it be prefixed with an underscore similar to _get_node_to_pick()? I\u0027m reading correctly it\u0027s used as a helper to allow build_git_tree to be more flexible - will it ever be consumed by end users?",
|
|
"range": {
|
|
"startLine": 47,
|
|
"startChar": 4,
|
|
"endLine": 47,
|
|
"endChar": 20
|
|
},
|
|
"revId": "c1ab539188b6f80723cff4581cabeb6970661f07",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9f6a8fd7_5d91f0f0",
|
|
"filename": "fixtures_git/__init__.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 47,
|
|
"author": {
|
|
"id": 1054
|
|
},
|
|
"writtenOn": "2018-04-30T12:55:17Z",
|
|
"side": 1,
|
|
"message": "I don\u0027t know, it might not be useful, it is sufficiently self contained that placing this and the method above in a separate utils module and leaving them both marked as \u0027_\u0027 should be sufficient?",
|
|
"parentUuid": "9f6a8fd7_22617d3a",
|
|
"range": {
|
|
"startLine": 47,
|
|
"startChar": 4,
|
|
"endLine": 47,
|
|
"endChar": 20
|
|
},
|
|
"revId": "c1ab539188b6f80723cff4581cabeb6970661f07",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9f6a8fd7_f8cfb2ad",
|
|
"filename": "fixtures_git/__init__.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 47,
|
|
"author": {
|
|
"id": 1390
|
|
},
|
|
"writtenOn": "2018-04-30T13:15:42Z",
|
|
"side": 1,
|
|
"message": "That sounds good to me",
|
|
"parentUuid": "9f6a8fd7_5d91f0f0",
|
|
"range": {
|
|
"startLine": 47,
|
|
"startChar": 4,
|
|
"endLine": 47,
|
|
"endChar": 20
|
|
},
|
|
"revId": "c1ab539188b6f80723cff4581cabeb6970661f07",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9f6a8fd7_6220d5f8",
|
|
"filename": "fixtures_git/__init__.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 186,
|
|
"author": {
|
|
"id": 1390
|
|
},
|
|
"writtenOn": "2018-04-30T11:50:39Z",
|
|
"side": 1,
|
|
"message": "May want to drop/generalise the reference to git-upstream here",
|
|
"range": {
|
|
"startLine": 181,
|
|
"startChar": 8,
|
|
"endLine": 186,
|
|
"endChar": 30
|
|
},
|
|
"revId": "c1ab539188b6f80723cff4581cabeb6970661f07",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5f7c97a3_a2d76ebf",
|
|
"filename": "fixtures_git/__init__.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 186,
|
|
"author": {
|
|
"id": 1054
|
|
},
|
|
"writtenOn": "2018-06-23T21:46:26Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "9f6a8fd7_6220d5f8",
|
|
"range": {
|
|
"startLine": 181,
|
|
"startChar": 8,
|
|
"endLine": 186,
|
|
"endChar": 30
|
|
},
|
|
"revId": "c1ab539188b6f80723cff4581cabeb6970661f07",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9f6a8fd7_7f54f1ca",
|
|
"filename": "fixtures_git/__init__.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 243,
|
|
"author": {
|
|
"id": 1054
|
|
},
|
|
"writtenOn": "2018-04-17T15:10:05Z",
|
|
"side": 1,
|
|
"message": "And place this class and the above one GitTree into a git.py file and import from there?\n\nThat way can add a github.py one specifically for two fixtures around creating a test repo and forking it to a second user under there.",
|
|
"revId": "c1ab539188b6f80723cff4581cabeb6970661f07",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9f6a8fd7_470923db",
|
|
"filename": "tests/base.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 19,
|
|
"author": {
|
|
"id": 1390
|
|
},
|
|
"writtenOn": "2018-04-30T11:50:39Z",
|
|
"side": 1,
|
|
"message": "Seems odd to reuse a builtin name here, though I guess if pep8 doesn\u0027t flag it\u0027s not so bad.",
|
|
"range": {
|
|
"startLine": 19,
|
|
"startChar": 31,
|
|
"endLine": 19,
|
|
"endChar": 34
|
|
},
|
|
"revId": "c1ab539188b6f80723cff4581cabeb6970661f07",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9f6a8fd7_9dca284d",
|
|
"filename": "tests/base.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 19,
|
|
"author": {
|
|
"id": 1054
|
|
},
|
|
"writtenOn": "2018-04-30T12:55:17Z",
|
|
"side": 1,
|
|
"message": "good point, I can change it to avoid that.",
|
|
"parentUuid": "9f6a8fd7_470923db",
|
|
"range": {
|
|
"startLine": 19,
|
|
"startChar": 31,
|
|
"endLine": 19,
|
|
"endChar": 34
|
|
},
|
|
"revId": "c1ab539188b6f80723cff4581cabeb6970661f07",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9f6a8fd7_1cab901d",
|
|
"filename": "tests/base.py",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 42,
|
|
"author": {
|
|
"id": 5557
|
|
},
|
|
"writtenOn": "2018-04-17T07:36:15Z",
|
|
"side": 1,
|
|
"message": "Ok - makes sense now.",
|
|
"range": {
|
|
"startLine": 42,
|
|
"startChar": 11,
|
|
"endLine": 42,
|
|
"endChar": 50
|
|
},
|
|
"revId": "c1ab539188b6f80723cff4581cabeb6970661f07",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |