fixtures-git/15eb36a98ce4bb4ca6c1127d03735a195bca17b6
Gerrit User 5557 4add42c247 Update patch set 2
Patch Set 2:

(1 comment)

Patch-set: 2
2018-12-12 15:17:14 +00:00

145 lines
4.3 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "3f79a3b5_001a6380",
"filename": "fixtures_git/github.py",
"patchSetId": 2
},
"lineNbr": 32,
"author": {
"id": 5557
},
"writtenOn": "2018-12-12T11:21:13Z",
"side": 1,
"message": "Any reason not to make this just a standalone method and avoid the mixin pattern ?",
"range": {
"startLine": 32,
"startChar": 8,
"endLine": 32,
"endChar": 13
},
"revId": "15eb36a98ce4bb4ca6c1127d03735a195bca17b6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_f583604e",
"filename": "fixtures_git/github.py",
"patchSetId": 2
},
"lineNbr": 32,
"author": {
"id": 1054
},
"writtenOn": "2018-12-12T14:51:00Z",
"side": 1,
"message": "none any more, I started it more to originally be able to set \u0027self.github\u0027 and then refactored it for testing, so it could be switched.",
"parentUuid": "3f79a3b5_001a6380",
"range": {
"startLine": 32,
"startChar": 8,
"endLine": 32,
"endChar": 13
},
"revId": "15eb36a98ce4bb4ca6c1127d03735a195bca17b6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_c6e32439",
"filename": "fixtures_git/github.py",
"patchSetId": 2
},
"lineNbr": 71,
"author": {
"id": 5557
},
"writtenOn": "2018-12-12T11:21:13Z",
"side": 1,
"message": "I would have found this difficult to understand without the benefit of the commit message - worth a comment IMO.",
"range": {
"startLine": 69,
"startChar": 8,
"endLine": 71,
"endChar": 41
},
"revId": "15eb36a98ce4bb4ca6c1127d03735a195bca17b6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_06d91c80",
"filename": "fixtures_git/github.py",
"patchSetId": 2
},
"lineNbr": 72,
"author": {
"id": 5557
},
"writtenOn": "2018-12-12T11:21:13Z",
"side": 1,
"message": "Is there any point to using tempfile, the file will be deleted after _setUp() ?",
"range": {
"startLine": 72,
"startChar": 7,
"endLine": 72,
"endChar": 73
},
"revId": "15eb36a98ce4bb4ca6c1127d03735a195bca17b6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_95554cc7",
"filename": "fixtures_git/github.py",
"patchSetId": 2
},
"lineNbr": 72,
"author": {
"id": 1054
},
"writtenOn": "2018-12-12T14:51:00Z",
"side": 1,
"message": "Guess I could use something else to replace the \u0027XXXXXX\u0027 part, originally it was based on the assumption that might need a corresponding temp directory to place initial repo contents.\n\nThe result would probably be something like the following:\n\n self.repo_name \u003d \u0027\u0027.join(\n prefix,\n (random.choice(string.ascii_uppercase + string.digits) \n for _ in range(8))),\n suffix\n )\n\nIs that reasonably clear?",
"parentUuid": "3f79a3b5_06d91c80",
"range": {
"startLine": 72,
"startChar": 7,
"endLine": 72,
"endChar": 73
},
"revId": "15eb36a98ce4bb4ca6c1127d03735a195bca17b6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_60ab1091",
"filename": "fixtures_git/github.py",
"patchSetId": 2
},
"lineNbr": 72,
"author": {
"id": 5557
},
"writtenOn": "2018-12-12T15:17:14Z",
"side": 1,
"message": "Would uuid.uuid4() give u a useable string?",
"parentUuid": "3f79a3b5_95554cc7",
"range": {
"startLine": 72,
"startChar": 7,
"endLine": 72,
"endChar": 73
},
"revId": "15eb36a98ce4bb4ca6c1127d03735a195bca17b6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}