133 lines
4.0 KiB
Plaintext
133 lines
4.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_6903d074",
|
|
"filename": "fixtures_git/gitfixture.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 295,
|
|
"author": {
|
|
"id": 5557
|
|
},
|
|
"writtenOn": "2019-05-22T13:51:52Z",
|
|
"side": 1,
|
|
"message": "I think a docstring would be useful here even just to note that the username/password are not used for the initial clone, even if set.",
|
|
"revId": "5bb72719fce93a93cf79169436088012281280d7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_5faeba98",
|
|
"filename": "fixtures_git/gitfixture.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 295,
|
|
"author": {
|
|
"id": 1054
|
|
},
|
|
"writtenOn": "2019-05-22T14:56:30Z",
|
|
"side": 1,
|
|
"message": "Updated the code to use the username/password if username is set",
|
|
"parentUuid": "bfb3d3c7_6903d074",
|
|
"revId": "5bb72719fce93a93cf79169436088012281280d7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_8995e4e6",
|
|
"filename": "fixtures_git/gitfixture.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 315,
|
|
"author": {
|
|
"id": 5557
|
|
},
|
|
"writtenOn": "2019-05-22T13:51:52Z",
|
|
"side": 1,
|
|
"message": "Change to:\n\n if self.username:\n\n?\n\n(Setting self.username to \u0027\u0027 could result in a badly-formatted auth component of the recomposed url)",
|
|
"range": {
|
|
"startLine": 315,
|
|
"startChar": 8,
|
|
"endLine": 315,
|
|
"endChar": 36
|
|
},
|
|
"revId": "5bb72719fce93a93cf79169436088012281280d7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_dfc06a2d",
|
|
"filename": "fixtures_git/gitfixture.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 315,
|
|
"author": {
|
|
"id": 1054
|
|
},
|
|
"writtenOn": "2019-05-22T14:56:30Z",
|
|
"side": 1,
|
|
"message": "Not necessarily, I believe tokens are an accepted and in which case you might want to set username to \u0027\u0027 and password to the token or vice versa and the filter will remove the unset variable (works with None or \u0027\u0027) from the list returned to ensure that auth is just the \u0027token\u0027 by itself instead of \u0027:token\u0027 or \u0027token:\u0027 as would be the case otherwise.",
|
|
"parentUuid": "bfb3d3c7_8995e4e6",
|
|
"range": {
|
|
"startLine": 315,
|
|
"startChar": 8,
|
|
"endLine": 315,
|
|
"endChar": 36
|
|
},
|
|
"revId": "5bb72719fce93a93cf79169436088012281280d7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_c96d1c99",
|
|
"filename": "fixtures_git/gitfixture.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 317,
|
|
"author": {
|
|
"id": 5557
|
|
},
|
|
"writtenOn": "2019-05-22T13:51:52Z",
|
|
"side": 1,
|
|
"message": "This seems redundant since auth, and presumably url_parts[1], will always be set.",
|
|
"range": {
|
|
"startLine": 317,
|
|
"startChar": 30,
|
|
"endLine": 317,
|
|
"endChar": 37
|
|
},
|
|
"revId": "5bb72719fce93a93cf79169436088012281280d7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfb3d3c7_9fa432bb",
|
|
"filename": "fixtures_git/gitfixture.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 317,
|
|
"author": {
|
|
"id": 1054
|
|
},
|
|
"writtenOn": "2019-05-22T14:56:30Z",
|
|
"side": 1,
|
|
"message": "Removed, thanks.",
|
|
"parentUuid": "bfb3d3c7_c96d1c99",
|
|
"range": {
|
|
"startLine": 317,
|
|
"startChar": 30,
|
|
"endLine": 317,
|
|
"endChar": 37
|
|
},
|
|
"revId": "5bb72719fce93a93cf79169436088012281280d7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |