x
/
fuel-ccp-ceph
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(2 comments)

Patch-set: 1
Reviewer: Gerrit User 708 <708@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 708 2016-10-19 11:30:19 +00:00 committed by Gerrit Code Review
parent 10cfe7e400
commit 66ebd4bab8
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
e95687177902d7aa96d0ea4d31fc2884fe215347 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "fa6399be_ab1508e6",
"filename": "docker/radosgw/Dockerfile.j2",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 708
},
"writtenOn": "2016-10-19T11:30:19Z",
"side": 1,
"message": "Please change this to\n\n {{ image_spec(\"openstack-base\") }}\n\n(it won\u0027t work otherwise now)",
"revId": "e95687177902d7aa96d0ea4d31fc2884fe215347",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa6399be_6b77703b",
"filename": "service/files/ceph.conf.j2",
"patchSetId": 1
},
"lineNbr": 3,
"author": {
"id": 708
},
"writtenOn": "2016-10-19T11:30:19Z",
"side": 1,
"message": "Do we really need initial_members here? They seem to be required for mons only.",
"revId": "e95687177902d7aa96d0ea4d31fc2884fe215347",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}