From 94d3facf4f3ad14376743b073e18d4ad6adc1724 Mon Sep 17 00:00:00 2001 From: Peter Razumovsky Date: Mon, 6 Feb 2017 16:56:37 +0400 Subject: [PATCH] Add linter and bashate tox checks For correct job succeed need to add tox checkers. Change-Id: Ic9e74e3461928efc2f7ffed5be17372ed5add554 --- .gitignore | 68 +++++++++++++++++++++++++++++++++++++++++++++ tools/yamllint.sh | 6 ++++ tools/yamllint.yaml | 21 ++++++++++++++ tox.ini | 17 ++++++++++++ 4 files changed, 112 insertions(+) create mode 100644 .gitignore create mode 100755 tools/yamllint.sh create mode 100644 tools/yamllint.yaml create mode 100644 tox.ini diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..a090978 --- /dev/null +++ b/.gitignore @@ -0,0 +1,68 @@ +*.py[cod] + +# C extensions +*.so + +# Packages +*.egg +*.egg-info +dist +build +.eggs +eggs +parts +bin +var +sdist +develop-eggs +.installed.cfg +lib +lib64 + +# Installer logs +pip-log.txt + +# Unit test / coverage reports +.coverage +cover +.tox +nosetests.xml +.testrepository +.venv + +# Translations +*.mo + +# Mr Developer +.mr.developer.cfg +.project +.pydevproject + +# Complexity +output/*.html +output/*/index.html + +# Sphinx +doc/build + +# oslo-config-generator +etc/*.sample + +# pbr generates these +AUTHORS +ChangeLog + +# Editors +*~ +.*.swp +.*sw? + +# Vagrant +.vagrant +vagrant/Vagrantfile.custom +vagrant/vagrantkey* + +# generated openrc +openrc + +tests/.cache* \ No newline at end of file diff --git a/tools/yamllint.sh b/tools/yamllint.sh new file mode 100755 index 0000000..0929f77 --- /dev/null +++ b/tools/yamllint.sh @@ -0,0 +1,6 @@ +#!/bin/bash +set -ex + +workdir=$(dirname $0) +finder=$(find . -not -path '*/\.*' -type f -name '*.yaml') +yamllint -c $workdir/yamllint.yaml $finder diff --git a/tools/yamllint.yaml b/tools/yamllint.yaml new file mode 100644 index 0000000..e72baa4 --- /dev/null +++ b/tools/yamllint.yaml @@ -0,0 +1,21 @@ +extends: default + +rules: + braces: + max-spaces-inside: 1 + comments: + level: error + comments-indentation: + level: warning + document-end: + present: false + document-start: + level: error + present: false + empty-lines: + max: 1 + max-start: 0 + max-end: 0 + line-length: + level: warning + max: 120 diff --git a/tox.ini b/tox.ini new file mode 100644 index 0000000..3c1338c --- /dev/null +++ b/tox.ini @@ -0,0 +1,17 @@ +[tox] +minversion = 1.6 +envlist = linters,bashate +skipsdist = True + +[testenv:venv] +commands = {posargs} + +[testenv:linters] +deps = yamllint +commands = + {toxinidir}/tools/yamllint.sh + +[testenv:bashate] +deps = bashate>=0.2 +whitelist_externals = bash +commands = bash -c "find {toxinidir} -type f -name '*.sh' -not -path '*/.tox/*' -print0 | xargs -0 bashate -v"