From 953fd13907913efa40eb7821399cc50927f878ff Mon Sep 17 00:00:00 2001 From: Gerrit User 12039 <12039@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 6 Feb 2017 16:10:12 +0000 Subject: [PATCH] Update patch set 11 Patch Set 11: Code-Review-1 (3 comments) Patch-set: 11 Label: Code-Review=-1 --- 96316b129a43ee147cd4cd6caa55ac7bb6359882 | 73 ++++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 96316b129a43ee147cd4cd6caa55ac7bb6359882 diff --git a/96316b129a43ee147cd4cd6caa55ac7bb6359882 b/96316b129a43ee147cd4cd6caa55ac7bb6359882 new file mode 100644 index 0000000..5911f75 --- /dev/null +++ b/96316b129a43ee147cd4cd6caa55ac7bb6359882 @@ -0,0 +1,73 @@ +{ + "comments": [ + { + "key": { + "uuid": "1a430d35_bca6090e", + "filename": "fuel_ccp_entrypoint/start_script.py", + "patchSetId": 11 + }, + "lineNbr": 186, + "author": { + "id": 12039 + }, + "writtenOn": "2017-02-06T16:10:12Z", + "side": 1, + "message": "let\u0027s let the address function to decide if we need http or https here", + "range": { + "startLine": 181, + "startChar": 8, + "endLine": 186, + "endChar": 61 + }, + "revId": "96316b129a43ee147cd4cd6caa55ac7bb6359882", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "1a430d35_dcf755f3", + "filename": "fuel_ccp_entrypoint/start_script.py", + "patchSetId": 11 + }, + "lineNbr": 223, + "author": { + "id": 12039 + }, + "writtenOn": "2017-02-06T16:10:12Z", + "side": 1, + "message": "let\u0027s use list or tuple", + "range": { + "startLine": 223, + "startChar": 4, + "endLine": 223, + "endChar": 16 + }, + "revId": "96316b129a43ee147cd4cd6caa55ac7bb6359882", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "1a430d35_1c939da4", + "filename": "fuel_ccp_entrypoint/start_script.py", + "patchSetId": 11 + }, + "lineNbr": 225, + "author": { + "id": 12039 + }, + "writtenOn": "2017-02-06T16:10:12Z", + "side": 1, + "message": "let\u0027s explicitly define services", + "range": { + "startLine": 225, + "startChar": 9, + "endLine": 225, + "endChar": 27 + }, + "revId": "96316b129a43ee147cd4cd6caa55ac7bb6359882", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file