x/fuel-ccp-galera
Code Issues Proposed changes
8444a851e6
fuel-ccp-galera/1575c592dacffd9829027dd9dd6946c97e8ebd14
Gerrit User 7710 91ef395fde Update patch set 1 
Patch Set 1:

(8 comments)

Patch-set: 1
2017-03-14 08:37:48 +00:00

332 lines
8.7 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "ba2be162_60c5d659",
"filename": "docker/mysql-client/Dockerfile.j2",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 18652
},
"writtenOn": "2017-03-02T09:47:47Z",
"side": 1,
"message": "Why do we need it at all, if we already have a \"percona\" container?",
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba2be162_e0162654",
"filename": "docker/mysql-client/Dockerfile.j2",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 7710
},
"writtenOn": "2017-03-14T08:37:48Z",
"side": 1,
"message": "percona container doesn\u0027t contain mysql client.\n\n \u0026\u0026 apt-get install -y --force-yes --no-install-recommends percona-xtradb-cluster-57 jq \\",
"parentUuid": "ba2be162_60c5d659",
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba2be162_601796ed",
"filename": "docker/mysql-client/Dockerfile.j2",
"patchSetId": 1
},
"lineNbr": 5,
"author": {
"id": 18652
},
"writtenOn": "2017-03-02T09:47:47Z",
"side": 1,
"message": "why?",
"range": {
"startLine": 5,
"startChar": 26,
"endLine": 5,
"endChar": 37
},
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba2be162_9b2a3b7d",
"filename": "docker/mysql-client/Dockerfile.j2",
"patchSetId": 1
},
"lineNbr": 5,
"author": {
"id": 7710
},
"writtenOn": "2017-03-14T08:37:48Z",
"side": 1,
"message": "copy-pasted from percona container",
"parentUuid": "ba2be162_601796ed",
"range": {
"startLine": 5,
"startChar": 26,
"endLine": 5,
"endChar": 37
},
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba2be162_2092fe57",
"filename": "service/actions/backup-db.yaml",
"patchSetId": 1
},
"lineNbr": 9,
"author": {
"id": 18652
},
"writtenOn": "2017-03-02T09:47:47Z",
"side": 1,
"message": "/opt/ccp/bin",
"range": {
"startLine": 9,
"startChar": 13,
"endLine": 9,
"endChar": 21
},
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a22e58a_94035276",
"filename": "service/actions/backup-db.yaml",
"patchSetId": 1
},
"lineNbr": 9,
"author": {
"id": 7710
},
"writtenOn": "2017-03-14T08:37:48Z",
"side": 1,
"message": "Done",
"parentUuid": "ba2be162_2092fe57",
"range": {
"startLine": 9,
"startChar": 13,
"endLine": 9,
"endChar": 21
},
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba2be162_40a1b2a2",
"filename": "service/actions/backup-db.yaml",
"patchSetId": 1
},
"lineNbr": 11,
"author": {
"id": 18652
},
"writtenOn": "2017-03-02T09:47:47Z",
"side": 1,
"message": "ditto",
"range": {
"startLine": 11,
"startChar": 14,
"endLine": 11,
"endChar": 22
},
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a22e58a_b4084e93",
"filename": "service/actions/backup-db.yaml",
"patchSetId": 1
},
"lineNbr": 11,
"author": {
"id": 7710
},
"writtenOn": "2017-03-14T08:37:48Z",
"side": 1,
"message": "Done",
"parentUuid": "ba2be162_40a1b2a2",
"range": {
"startLine": 11,
"startChar": 14,
"endLine": 11,
"endChar": 22
},
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba2be162_c0368251",
"filename": "service/files/backup-db.sh.j2",
"patchSetId": 1
},
"lineNbr": 2,
"author": {
"id": 18652
},
"writtenOn": "2017-03-02T09:47:47Z",
"side": 1,
"message": "this is ok, yet plain text dump is very slow to do and very very slow to load. We need an xtrabackup solution too",
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5a22e58a_7f486f5c",
"filename": "service/files/backup-db.sh.j2",
"patchSetId": 1
},
"lineNbr": 2,
"author": {
"id": 7710
},
"writtenOn": "2017-03-14T08:37:48Z",
"side": 1,
"message": "I\u0027ll create separate action for this.",
"parentUuid": "ba2be162_c0368251",
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba2be162_e09d465a",
"filename": "service/files/backup-db.sh.j2",
"patchSetId": 1
},
"lineNbr": 6,
"author": {
"id": 18652
},
"writtenOn": "2017-03-02T09:47:47Z",
"side": 1,
"message": "add \"-\" here",
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba2be162_60aa3672",
"filename": "service/files/backup-db.sh.j2",
"patchSetId": 1
},
"lineNbr": 6,
"author": {
"id": 18652
},
"writtenOn": "2017-03-02T09:47:47Z",
"side": 1,
"message": "not sure if you need seconds",
"range": {
"startLine": 6,
"startChar": 66,
"endLine": 6,
"endChar": 68
},
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba2be162_7b83c756",
"filename": "service/files/backup-db.sh.j2",
"patchSetId": 1
},
"lineNbr": 6,
"author": {
"id": 7710
},
"writtenOn": "2017-03-14T08:37:48Z",
"side": 1,
"message": "why? in upgrade we use seconds.",
"parentUuid": "ba2be162_60aa3672",
"range": {
"startLine": 6,
"startChar": 66,
"endLine": 6,
"endChar": 68
},
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba2be162_9b86bb63",
"filename": "service/files/backup-db.sh.j2",
"patchSetId": 1
},
"lineNbr": 6,
"author": {
"id": 7710
},
"writtenOn": "2017-03-14T08:37:48Z",
"side": 1,
"message": "where?",
"parentUuid": "ba2be162_e09d465a",
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba2be162_8013aab7",
"filename": "service/files/backup-db.sh.j2",
"patchSetId": 1
},
"lineNbr": 12,
"author": {
"id": 18652
},
"writtenOn": "2017-03-02T09:47:47Z",
"side": 1,
"message": "\"--routines --triggers\"",
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba2be162_fbded76b",
"filename": "service/files/backup-db.sh.j2",
"patchSetId": 1
},
"lineNbr": 12,
"author": {
"id": 7710
},
"writtenOn": "2017-03-14T08:37:48Z",
"side": 1,
"message": "Done",
"parentUuid": "ba2be162_8013aab7",
"revId": "1575c592dacffd9829027dd9dd6946c97e8ebd14",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink